Commit 84427943d2da ("greybus: svc: drop legacy-protocol dependency") removed these implementations but not the declarations.
Signed-off-by: Yue Haibing yuehaibing@huawei.com --- include/linux/greybus/svc.h | 3 --- 1 file changed, 3 deletions(-)
diff --git a/include/linux/greybus/svc.h b/include/linux/greybus/svc.h index 5afaf5f06856..da547fb9071b 100644 --- a/include/linux/greybus/svc.h +++ b/include/linux/greybus/svc.h @@ -100,7 +100,4 @@ bool gb_svc_watchdog_enabled(struct gb_svc *svc); int gb_svc_watchdog_enable(struct gb_svc *svc); int gb_svc_watchdog_disable(struct gb_svc *svc);
-int gb_svc_protocol_init(void); -void gb_svc_protocol_exit(void); - #endif /* __SVC_H */
On Fri, Aug 18, 2023 at 08:43:38PM +0800, Yue Haibing wrote:
Commit 84427943d2da ("greybus: svc: drop legacy-protocol dependency") removed these implementations but not the declarations.
Signed-off-by: Yue Haibing yuehaibing@huawei.com
include/linux/greybus/svc.h | 3 --- 1 file changed, 3 deletions(-)
diff --git a/include/linux/greybus/svc.h b/include/linux/greybus/svc.h index 5afaf5f06856..da547fb9071b 100644 --- a/include/linux/greybus/svc.h +++ b/include/linux/greybus/svc.h @@ -100,7 +100,4 @@ bool gb_svc_watchdog_enabled(struct gb_svc *svc); int gb_svc_watchdog_enable(struct gb_svc *svc); int gb_svc_watchdog_disable(struct gb_svc *svc); -int gb_svc_protocol_init(void); -void gb_svc_protocol_exit(void);
#endif /* __SVC_H */
2.34.1
Nice, how did you find these?
On 2023/8/22 22:32, Greg KH wrote:
On Fri, Aug 18, 2023 at 08:43:38PM +0800, Yue Haibing wrote:
Commit 84427943d2da ("greybus: svc: drop legacy-protocol dependency") removed these implementations but not the declarations.
Signed-off-by: Yue Haibing yuehaibing@huawei.com
include/linux/greybus/svc.h | 3 --- 1 file changed, 3 deletions(-)
diff --git a/include/linux/greybus/svc.h b/include/linux/greybus/svc.h index 5afaf5f06856..da547fb9071b 100644 --- a/include/linux/greybus/svc.h +++ b/include/linux/greybus/svc.h @@ -100,7 +100,4 @@ bool gb_svc_watchdog_enabled(struct gb_svc *svc); int gb_svc_watchdog_enable(struct gb_svc *svc); int gb_svc_watchdog_disable(struct gb_svc *svc); -int gb_svc_protocol_init(void); -void gb_svc_protocol_exit(void);
#endif /* __SVC_H */
2.34.1
Nice, how did you find these?
Just use grep to check like below, then filter out known false item
grep -rP --include=*.h '^(?:\w+\s+){1,3}*{0,3}\s{0,3}\w+[\t]*(' * |grep -P -oh '\w+\s*('|sort| uniq -c| sort -n| grep -P '^\s+1\b'|sed -r -e 's/^\s+1\s+//' -e 's/(//'|while read line ; do CNT=`git grep -w $line |wc -l` ; if [ $CNT -eq 1 ];then git grep -wn $line fi done
.
On Fri, Aug 18, 2023 at 08:43:38PM +0800, Yue Haibing wrote:
Commit 84427943d2da ("greybus: svc: drop legacy-protocol dependency") removed these implementations but not the declarations.
Signed-off-by: Yue Haibing yuehaibing@huawei.com
include/linux/greybus/svc.h | 3 --- 1 file changed, 3 deletions(-)
diff --git a/include/linux/greybus/svc.h b/include/linux/greybus/svc.h index 5afaf5f06856..da547fb9071b 100644 --- a/include/linux/greybus/svc.h +++ b/include/linux/greybus/svc.h @@ -100,7 +100,4 @@ bool gb_svc_watchdog_enabled(struct gb_svc *svc); int gb_svc_watchdog_enable(struct gb_svc *svc); int gb_svc_watchdog_disable(struct gb_svc *svc); -int gb_svc_protocol_init(void); -void gb_svc_protocol_exit(void);
#endif /* __SVC_H */
Yup, these are long gone:
Reviewed-by: Johan Hovold johan@kernel.org
Johan
-
Greg KH -
Johan Hovold -
Yue Haibing