On Tue, Feb 22, 2011 at 4:38 PM, Amit Kucheria amit.kucheria@linaro.org wrote:
Hi,
We're required to cc patches@linaro.org for all patches that we send upstream. bzr/launchpad users are already covered or will be shortly.
For those using git-send-email to send patches (and you really should be), it might make sense to use the following command so you don't forget
$ git config --global --add sendemail.bcc "patches@linaro.org"
Check $HOME/.gitconfig to make sure you see "bcc = patches@linaro.org" under the [sendemail] section. WARNING - this will bcc patches@linaro.org on all patches from that machine sent using git-send-email.
If you want more control, and your linaro work happens in a single git tree, you could do the following:
$ cd <your linaro git tree> $ git config --add sendemail.bcc "patches@linaro.org"
Check <your linaro git tree>/.git/config for the bcc entry as above. Now patches send from that tree will be bcc'ed to patches@linaro.
/Amit p.s. There is also a sendemail.cc instead of sendemail.bcc in case you want to use that.
Do we need a policy on whether or not to use Bcc here?
One argument for using Bcc is that it avoids replies from subscribers to the destination mailing lists from also being CC'd to patches@linaro.org. Can your analysis cope with patches@linaro.org receiving a whole thread, or do we need to be careful about this?
Cheers ---Dave
On Tue, Feb 22, 2011 at 05:02:41PM +0000, Dave Martin wrote:
Do we need a policy on whether or not to use Bcc here?
One argument for using Bcc is that it avoids replies from subscribers to the destination mailing lists from also being CC'd to patches@linaro.org. Can your analysis cope with patches@linaro.org receiving a whole thread, or do we need to be careful about this?
Use CC, not BCC.
There is no issue with people replying to patches@linaro.org; we will use the headers to ensure we're not double-counting, and having the whole thread actually helps us hint if the patches were upstreamed or not.
On Tue, Feb 22, 2011 at 5:15 PM, Christian Robottom Reis kiko@linaro.org wrote:
On Tue, Feb 22, 2011 at 05:02:41PM +0000, Dave Martin wrote:
Do we need a policy on whether or not to use Bcc here?
One argument for using Bcc is that it avoids replies from subscribers to the destination mailing lists from also being CC'd to patches@linaro.org. Can your analysis cope with patches@linaro.org receiving a whole thread, or do we need to be careful about this?
Use CC, not BCC.
There is no issue with people replying to patches@linaro.org; we will use the headers to ensure we're not double-counting, and having the whole thread actually helps us hint if the patches were upstreamed or not.
OK-- if you're confident that the analysis won't break, and that no bounces will come from patches@linaro, then I agree -- there's no other reason for the CC to be "secret"
Cheers ---Dave
On Tue, Feb 22, 2011, Dave Martin wrote:
Do we need a policy on whether or not to use Bcc here?
One argument for using Bcc is that it avoids replies from subscribers to the destination mailing lists from also being CC'd to patches@linaro.org. Can your analysis cope with patches@linaro.org receiving a whole thread, or do we need to be careful about this?
The tool will likely have to cope no matter what, but I would think it's best to use Bcc: just to keep most issues away.
OK, we have a tie ;) Who wins?
On Tue, Feb 22, 2011 at 5:15 PM, Christian Robottom Reis kiko@linaro.org wrote:
On Tue, Feb 22, 2011 at 05:02:41PM +0000, Dave Martin wrote:
[...]
Use CC, not BCC.
[...]
On Tue, Feb 22, 2011 at 6:08 PM, Loïc Minier loic.minier@linaro.org wrote:
On Tue, Feb 22, 2011, Dave Martin wrote:
[...]
The tool will likely have to cope no matter what, but I would think it's best to use Bcc: just to keep most issues away.
Cheers ---Dave
On Tue, Feb 22, 2011 at 06:58:28PM +0000, Dave Martin wrote:
OK, we have a tie ;) Who wins?
On Tue, Feb 22, 2011 at 5:15 PM, Christian Robottom Reis kiko@linaro.org wrote:
On Tue, Feb 22, 2011 at 05:02:41PM +0000, Dave Martin wrote:
[...]
Use CC, not BCC.
[...]
ME! :)
On Tue, 2011-02-22 at 16:41 -0300, Christian Robottom Reis wrote:
On Tue, Feb 22, 2011 at 06:58:28PM +0000, Dave Martin wrote:
OK, we have a tie ;) Who wins?
On Tue, Feb 22, 2011 at 5:15 PM, Christian Robottom Reis kiko@linaro.org wrote:
On Tue, Feb 22, 2011 at 05:02:41PM +0000, Dave Martin wrote:
[...]
Use CC, not BCC.
[...]
ME! :)
Yea. Since I still send out patches from both my employer and linaro address, I can't utilize fixed git config values.
I already put the effort in to make sure my linaro work has my linaro.org address as the author on a patch by patch basis. And similarly I can add a CC: line to the patch commit log to make sure patches@linaro.org gets the mail.
But BCC isn't easy to do on a patch-by-patch basis.
thanks -john
On Tue, Feb 22, 2011, john stultz wrote:
Yea. Since I still send out patches from both my employer and linaro address, I can't utilize fixed git config values.
I already put the effort in to make sure my linaro work has my linaro.org address as the author on a patch by patch basis. And similarly I can add a CC: line to the patch commit log to make sure patches@linaro.org gets the mail.
But BCC isn't easy to do on a patch-by-patch basis.
That's fair enough; could you explain how you're doing this patch by patch?
I personally set author via the EMAIL env var and I have aliases like: linaro='EMAIL="loic.minier@linaro.org"' debian='EMAIL="lool@debian.org"' etc. and then I run: linaro git commit -av
I wonder how you set Cc: though
On Tue, 2011-02-22 at 22:18 +0100, Loïc Minier wrote:
On Tue, Feb 22, 2011, john stultz wrote:
Yea. Since I still send out patches from both my employer and linaro address, I can't utilize fixed git config values.
I already put the effort in to make sure my linaro work has my linaro.org address as the author on a patch by patch basis. And similarly I can add a CC: line to the patch commit log to make sure patches@linaro.org gets the mail.
But BCC isn't easy to do on a patch-by-patch basis.
That's fair enough; could you explain how you're doing this patch by patch?
I personally set author via the EMAIL env var and I have aliases like: linaro='EMAIL="loic.minier@linaro.org"' debian='EMAIL="lool@debian.org"' etc. and then I run: linaro git commit -av
I wonder how you set Cc: though
Add to the commit log:
CC: Loïc Minier loic.minier@linaro.org CC: patches@linaro.org
And git-send-email will add those entries to the outgoing mail.
thanks -john
On Tue, Feb 22, 2011, john stultz wrote:
Add to the commit log: CC: Loïc Minier loic.minier@linaro.org CC: patches@linaro.org And git-send-email will add those entries to the outgoing mail.
Ah, so it's in the commit forever; I thought you were adding that at send-email time; ok, thanks!
Hi All,
For some upstream projects, we don't use git-send-mail to send patch for review. Take KDE/Kwin project for example, post-review and the reviewboard[1] are used for patch review. How shall we handle such kind of cases?
[1] https://git.reviewboard.kde.org/
Regards, Jammy
On Wed, Feb 23, 2011 at 6:19 AM, Loïc Minier loic.minier@linaro.org wrote:
On Tue, Feb 22, 2011, john stultz wrote:
Add to the commit log: CC: Loïc Minier loic.minier@linaro.org CC: patches@linaro.org And git-send-email will add those entries to the outgoing mail.
Ah, so it's in the commit forever; I thought you were adding that at send-email time; ok, thanks!
-- Loïc Minier
linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
Just a thought in the other way: will it be useful to to have some web crawler to collect those activities as long as we all use linaro email addresses? For mails like patch within, there should be some thing we can identify.
On Wed, Feb 23, 2011 at 10:09 AM, Jammy Zhou jammy.zhou@linaro.org wrote:
Hi All,
For some upstream projects, we don't use git-send-mail to send patch for review. Take KDE/Kwin project for example, post-review and the reviewboard[1] are used for patch review. How shall we handle such kind of cases?
[1] https://git.reviewboard.kde.org/
Regards, Jammy
On Wed, Feb 23, 2011 at 6:19 AM, Loïc Minier loic.minier@linaro.org wrote:
On Tue, Feb 22, 2011, john stultz wrote:
Add to the commit log: CC: Loïc Minier loic.minier@linaro.org CC: patches@linaro.org And git-send-email will add those entries to the outgoing mail.
Ah, so it's in the commit forever; I thought you were adding that at send-email time; ok, thanks!
-- Loïc Minier
linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
On Wed, 2011-02-23 at 11:19 +0800, Eric Miao wrote:
Just a thought in the other way: will it be useful to to have some web crawler to collect those activities as long as we all use linaro email addresses? For mails like patch within, there should be some thing we can identify.
I don't think that'd work in practice because web UIs usually either hide or mangle email addresses.
On Wed, Feb 23, 2011 at 10:09 AM, Jammy Zhou jammy.zhou@linaro.org wrote:
Hi All,
For some upstream projects, we don't use git-send-mail to send patch for review. Take KDE/Kwin project for example, post-review and the reviewboard[1] are used for patch review. How shall we handle such kind of cases?
[1] https://git.reviewboard.kde.org/
Regards, Jammy
On Wed, Feb 23, 2011 at 6:19 AM, Loïc Minier loic.minier@linaro.org wrote:
On Tue, Feb 22, 2011, john stultz wrote:
Add to the commit log: CC: Loïc Minier loic.minier@linaro.org CC: patches@linaro.org And git-send-email will add those entries to the outgoing mail.
Ah, so it's in the commit forever; I thought you were adding that at send-email time; ok, thanks!
-- Loïc Minier
linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
On Wed, 2011-02-23 at 10:09 +0800, Jammy Zhou wrote:
Hi All,
For some upstream projects, we don't use git-send-mail to send patch for review. Take KDE/Kwin project for example, post-review and the reviewboard[1] are used for patch review. How shall we handle such kind of cases?
I suppose reviewboard sends out email to people with new patches? If so, maybe we could register a user there with the patches@linaro.org address and have it subscribed to the things we care about? This may not work well in practice if, for instance, we can't filter out what is not from Linaro, but maybe it's a start.
[1] https://git.reviewboard.kde.org/
Regards, Jammy
On Wed, Feb 23, 2011 at 6:19 AM, Loïc Minier loic.minier@linaro.org wrote: On Tue, Feb 22, 2011, john stultz wrote: > Add to the commit log: > CC: Loïc Minier loic.minier@linaro.org > CC: patches@linaro.org > And git-send-email will add those entries to the outgoing mail. Ah, so it's in the commit forever; I thought you were adding that at send-email time; ok, thanks! -- Loïc Minier _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
On Thu, Feb 24, 2011 at 4:46 AM, Guilherme Salgado salgado@canonical.comwrote:
On Wed, 2011-02-23 at 10:09 +0800, Jammy Zhou wrote:
Hi All,
For some upstream projects, we don't use git-send-mail to send patch for review. Take KDE/Kwin project for example, post-review and the reviewboard[1] are used for patch review. How shall we handle such kind of cases?
I suppose reviewboard sends out email to people with new patches? If so, maybe we could register a user there with the patches@linaro.org address and have it subscribed to the things we care about? This may not work well in practice if, for instance, we can't filter out what is not from Linaro, but maybe it's a start.
Yes, we can add people to the "Reviewers" section, but it seems that patches@linaro.org should be a registered user to be added. And maybe patches@linaro.org should be subscribed to the mail list for the projects we are working on.
Regards, Jammy
[1] https://git.reviewboard.kde.org/
Regards, Jammy
On Wed, Feb 23, 2011 at 6:19 AM, Loïc Minier loic.minier@linaro.org wrote: On Tue, Feb 22, 2011, john stultz wrote:
> Add to the commit log: > CC: Loïc Minier <loic.minier@linaro.org> > CC: patches@linaro.org > And git-send-email will add those entries to the outgoing mail. Ah, so it's in the commit forever; I thought you were adding that at send-email time; ok, thanks! -- Loïc Minier _______________________________________________ linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
linaro-dev mailing list linaro-dev@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-dev
-- Guilherme Salgado https://launchpad.net/~salgado
-
Christian Robottom Reis -
Dave Martin -
Eric Miao -
Guilherme Salgado -
Jammy Zhou -
john stultz -
Loïc Minier