Skia and webkit fixed float

Michael Trimarchi michael at amarulasolutions.com
Thu Mar 8 21:44:19 UTC 2012


Hi all,

I'm working on a PXA320 on gingerbread. After implementing the GCU graphics acceleration, I'm working on having skia and android using fixed float. It is not
a patch submission but give an idea about the problem that we have.

index a10371f..93c162f 100644
--- a/WebCore/platform/graphics/skia/FloatRectSkia.cpp
+++ b/WebCore/platform/graphics/skia/FloatRectSkia.cpp
@@ -36,14 +36,14 @@
 namespace WebCore {
 
 FloatRect::FloatRect(const SkRect& r)
-    : m_location(r.fLeft, r.fTop)
-    , m_size(r.width(), r.height())
+    : m_location(SkScalarToFloat(r.fLeft), SkScalarToFloat(r.fTop))
+    , m_size(SkScalarToFloat(r.width()), SkScalarToFloat(r.height()))
 {
 }
 
 FloatRect::operator SkRect() const
 {
-    SkRect rect = { x(), y(), right(), bottom() };
+    SkRect rect = { SkFloatToScalar(x()), SkFloatToScalar(y()), SkFloatToScalar(right()), SkFloatToScalar(bottom()) };
     return rect;
 }

This fix on the webcore help to start to render webpage. But there are several points to fix.
I would like to know if there is some interest on this topic

Michael





More information about the linaro-android mailing list