linaro-media-create bug fix for mx51evk
Wolfgang Denk
wd at denx.de
Thu Oct 14 04:36:07 UTC 2010
Dear Shawn Guo,
In message <AANLkTimK0HqF69uzq8oiD0TWaxUUXTsN1zzu_5ZeuMkN at mail.gmail.com> you wrote:
> The l-m-c is broken for mx51evk due to the following two bugs. I
> posted the patches there. Please review the patches and
> pick them up if they are ok.
>
> The bootcmd setting for mx51evk in l-m-c exceeds max args
> https://bugs.launchpad.net/linaro-image-tools/+bug/659720
>
> === modified file 'linaro-media-create'
> --- linaro-media-create 2010-10-12 15:31:29 +0000
> +++ linaro-media-create 2010-10-14 01:29:29 +0000
> @@ -361,7 +361,7 @@
>
> mx51evk)
> cat > ${TMP_DIR}/boot.cmd << BOOTCMD
> -setenv bootcmd 'mmcinfo; mmc init; fatload mmc 0:2 $KERNEL_ADDR
> uImage; fatload mmc 0:2 $INITRD_ADDR uInitrd; bootm $KERNEL_ADDR
> $INITRD_ADDR'
> +setenv bootcmd 'fatload mmc 0:2 $KERNEL_ADDR uImage; fatload mmc 0:2
> $INITRD_ADDR uInitrd; bootm $KERNEL_ADDR $INITRD_ADDR'
> setenv bootargs '${serial_opts} ${splash_opts} ${lowmem_opt}
> ${boot_snippet} rootwait ro'
> boot
> BOOTCMD
Another trivial change is just to omit some of the redundant spaces in
the command line: s/; /;/g
i.e. change into
setenv bootcmd 'mmcinfo;mmc init;fatload mmc 0:2 $KERNEL_ADDRuImage;fatload mmc 0:2 $INITRD_ADDR uInitrd;bootm $KERNEL_ADDR
The correct way to fix this is of course to submit a patch to U-Boot
to increase the CONFIG_MAX_ARGS option.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The price of curiosity is a terminal experience.
- Terry Pratchett, _The Dark Side of the Sun_
More information about the linaro-dev
mailing list