[clutter-gles] fix GL_INVALID_ENUM for glRenderbufferStorage

[Jammy Zhou]

Hi Alexandros,

That's great. And thanks for your guide on upstreaming patches to clutter. I
will upstream these two patches for a try then (Of course, I will add you to
CC ^_^)

Regards,
Jammy

On Mon, Sep 20, 2010 at 5:47 PM, Alexandros Frantzis <
alexandros.frantzis at linaro.org> wrote:

> On Sun, Sep 19, 2010 at 06:26:54PM +0800, Jammy Zhou wrote:
> > Hi Alexandros,
> >
> > I found a bug in clutter for gles. And I have prepared a patch as
> attached.
> > Could you please add it to our clutter branch? I think this patch should
> > also be upstreamable.
> >
> > By the way, could you please give some tips here to contribute to the
> > upstream clutter?
> >
> > Regards,
> > Jammy
>
>
> Hi Jammy!
>
> New packages including this patch and also the glUseProgram fix (for
> cogl-gles2-wrapper.c) are currently being built in
> ppa:afrantzis/clutter-1.2.
>
> The packaging branch for them is:
>
> lp:~linaro-user-platforms/ubuntu/maverick/clutter-1.0/clutter-1.0-linaro
>
> For upstreaming you should first register in the clutter bugzilla. Then
> just submit a bug report with the patch attached.  The patch should
> ideally be produced with "git format-patch" (as I think you are already
> doing).
>
> Depending on the nature of the bug you should submit patches both
> against the 1.2 and master branches, so that the changes make it both to
> the stable 1.2 branch (which we currently use) and the next stable
> release (1.4).
>
> I think the two outstanding patches that can be upstreamed are this one
> and also your glUseProgram fix in cogl-gles2-wrapper.c. Could you
> upstream that, too?
>
> Also, could you please CC me in the bugs so that I can track them?
>
> Thanks,
> Alexandros
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.linaro.org/pipermail/linaro-dev/attachments/20100920/1ff8e7f0/attachment.htm