[RFC PATCH 14/24] video: omap: include mach/irqs.h directly

Nicolas Pitre nicolas.pitre at linaro.org
Tue Aug 23 18:19:01 UTC 2011


On Tue, 23 Aug 2011, Venkatraman S wrote:

> From: Venkatraman S <venkat at linaro.org>
> 
> Do not depend on the generic irq header file to include the platform
> specific header file.
> 
> Signed-off-by: Venkatraman S <venkat at linaro.org>

This is wrong.

Obviously we don't want the generic <asm/irq.h> to include <mach/irqs.h> 
anymore, however we also want to get rid of any references to <mach/*.h> 
_outside_ of the machine specific directory too.

>  drivers/video/omap/lcdc.c  |    1 +
>  drivers/video/omap/sossi.c |    1 +

In this case the needed definitions are presumably only useful to those 
drivers, in which case they probably should be moved into those drivers 
directly, or better yet passed into struct resource instances.


Nicolas



More information about the linaro-dev mailing list