[RFC PATCH 19/24] hack: Define constant IRQ_BITMAP_BITS independent of NR_IRQS
Nicolas Pitre
nicolas.pitre at linaro.org
Tue Aug 23 18:55:31 UTC 2011
On Tue, 23 Aug 2011, Venkatraman S wrote:
> From: Venkatraman S <venkat at linaro.org>
>
> Currently a hack. Need to define a polite way of defining
> IRQ_BITMAP_BITS
>
> Signed-off-by: Venkatraman S <venkat at linaro.org>
Well... given how IRQ_BITMAP_BITS is used, it looks like simply having a
sufficiently high number is all that is needed. The current value
appears to be totally arbitrary (and having 8196 instead of 8192 there
is rather odd). So I think this shouldn't need to be defined in terms
of NR_IRQS at all in fact.
> ---
> kernel/irq/internals.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/irq/internals.h b/kernel/irq/internals.h
> index 6546431..60db644 100644
> --- a/kernel/irq/internals.h
> +++ b/kernel/irq/internals.h
> @@ -8,7 +8,7 @@
> #include <linux/irqdesc.h>
>
> #ifdef CONFIG_SPARSE_IRQ
> -# define IRQ_BITMAP_BITS (NR_IRQS + 8196)
> +# define IRQ_BITMAP_BITS (512 + 8196)
> #else
> # define IRQ_BITMAP_BITS NR_IRQS
> #endif
> --
> 1.7.1
>
More information about the linaro-dev
mailing list