[PATCH 01/12] kbuild: Allow configs from choice blocks to be selected.
grant.likely at secretlab.ca
Wed Mar 9 15:19:29 UTC 2011
On Wed, Mar 9, 2011 at 1:38 AM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Wednesday 09 March 2011 03:32:35 John Stultz wrote:
>> In looking at trying to replace defconfigs with kconfig fragments,
>> one limitation identified is that config items in choice blocks
>> cannot be selected by other config options.
>> One way to doge this would be to create non-visible meta options
>> that change the choice block's default, but that would require
>> additional meta-configs per-choice config, plus a conditional
>> default per meta-config. That just seemed too ugly.
>> So I looked into how to allow the choice default to be overrided
>> by a select statment, and the following patch is the result.
>> I'm very new to kconfig code, so I expect that my changes are
>> probably broken in some subtle way, but in my testing it seems
>> to work. The select only chagnes the default, which can be overrided
>> by the user via the menu. This allows kconfig fragments to work
>> for make defconfig, while not restricting user customization.
>> Thoughts and feedback (or alternate approaches) would be appreciated.
>> CC: Grant Likely <grant.likely at secretlab.ca>
>> CC: Jason Hui <jason.hui at linaro.org>
>> CC: patches at linaro.org
>> Signed-off-by: John Stultz <john.stultz at linaro.org>
> The patch looks fine to me (as far as my little Kconfig
> knowledge goes). Two comments about the submission form though:
> * Ideally, the initial description is split into two parts: one
> that is suitable as a changelog and the other that is your
> personal comment, including the "thanks" part, and put it below
> the --- line, so that git can automatically cut it.
> * I think you should also Cc the Kconfig maintainer, Roman
> Zippel <zippel at linux-m68k.org>, and linux-kbuild at vger.kernel.org.
And linux-kernel. This definitely needs wider circulation, and I'd
like to see a push to get this accepted upstream before adding it to
the Linaro kernel tree.
More information about the linaro-dev