[PATCH-Android] [android/external/elfcopy] Modified to eliminate build errors using GCC 4.5/4.6.

Arnd Bergmann arnd at arndb.de
Wed Mar 16 11:47:09 UTC 2011


On Wednesday 16 March 2011, Sachin Kamat wrote:
> --- a/elfcopy.c
> +++ b/elfcopy.c
> @@ -2456,7 +2456,6 @@ update_symbol_values(Elf *elf, GElf_Ehdr *ehdr,
>                             out why and also figure out whether the zero value should have
>                             been adjusted, after all.
>                          */
> -                        ASSERT(!(shdr_info[sym->st_shndx].shdr.sh_flags & SHF_ALLOC));
>                          ASSERT(shdr_info[i].shdr.sh_type == SHT_SYMTAB);
>                      }

Like the -Werror changes that Alexander commented on, this change
circumvents the error output, but does not address the underlying
problem. If you remove an assertion, that at least needs a very
good explanation why the assertion was incorrect in the first
place.

	Arnd



More information about the linaro-dev mailing list