[PATCH v3 5/5] clk: export tree topology and clk data via sysfs
tony at atomide.com
Wed Nov 23 16:59:04 UTC 2011
* Greg KH <greg at kroah.com> [111122 10:51]:
> On Tue, Nov 22, 2011 at 09:57:41AM -0800, Mike Turquette wrote:
> > > Ah, comments like this warm my heart.
> > >
> > > Come on, no abusing the kobject code please, if have problems with how
> > > the kernel core works, and it doesn't do things you want it to, then why
> > > not change it to work properly for you, or at the least, ASK ME!!!
> > Ok, I'm asking you now. There are two ways to solve this problem:
> > 1) have kobject core create the lists linking the objects but defer
> > allocations and any interactions with sysfs until later in the boot
> > sequence, OR
Please just make it all a loadable module using regular devices. That
makes the development a lot easier and as a side effect also guarantees
we're using standard interfaces.
Sure most platforms using it want it compiled in at least for now,
but in the long run it should be possible to load it when we get to
initramfs. For the early usage of clocks..
> > 2) my code can create a list of clks (the same way that clkdev does)
> > and defer kobject/sysfs stuff until later, which walks the list made
> > during early-boot
..let's plan on getting rid of the early usage of clocks instead so
you don't have the issue of deferring stuff.
> > #1 is most closely aligned with the code I have here, #2 presents
> > challenges that I haven't really though through. I know that OMAP
> > uses the clk framework VERY early in it's boot sequence, but as long
> > as the per-clk data is properly initialized then it should be OK.
> > What do you think?
We initialize clocksource/clockevent clocks early, but we can do that
without clock fwk initially, then let a clockevent driver take over
later on. That should solve your issues #1 and #2.
> #3 - use debugfs and don't try to create a sysfs interface for the clock
> structures :)
Sounds like the debugfs is the way to go :)
More information about the linaro-dev