[PATCH 2/4] pinctrl: Remove unsafe __refdata

Linus Walleij linus.walleij at linaro.org
Thu Oct 20 09:54:08 UTC 2011


On Thu, Oct 20, 2011 at 11:46 AM, Barry Song <21cnbao at gmail.com> wrote:

> 2011/10/20 Stephen Warren <swarren at nvidia.com>:
>> A pin controller's pin definitions are used both during pinctrl_register()
>> and pinctrl_unregister(). The latter happens outside of __init/__devinit
>> time, and hence it is unsafe to mark the pin array as __refdata.
>
> Thanks.
> Acked-by: Barry Song <Baohua.Song at csr.com>
>
> missed this when porting prima2 pinmux driver. is this __refdata used
> just due to a typo?

No the problem was I misunderstood what __refdata means.

It means it is kept around but can reference initidata.

But I thought it meant "kept around in general".

I don't think it's causing bugs actually because it wasn't referencing
any initdata. But it's better like this.

Thanks,
Linus Walleij



More information about the linaro-dev mailing list