[PATCH v2] ASoC: omap: convert per-board modules to platform drivers
Russell King - ARM Linux
linux at arm.linux.org.uk
Thu Sep 8 23:01:02 UTC 2011
On Thu, Sep 08, 2011 at 03:47:31PM -0700, Mark Brown wrote:
> On Thu, Sep 08, 2011 at 11:37:20PM +0100, Russell King - ARM Linux wrote:
> > With DT of course, all devices get instantiated from the device tree,
> > so there should not be any more platform specific chunks of code in
> > these locations (ha, it couldn't be solved with platform data so I
> > suspect it will continue to persist, forever unsolved.)
> That's not the case at all for audio, the PCB schematic for the audio
> subsystem on a device like a smartphone is a sufficiently interesting
> piece of hardware to be a device with a driver in its own right. The
> ASoC machine drivers aren't about instantiating devices, they are about
> controlling the interrelationships between the various devices in the
> audio subsystem.
> What will happen for device tree is that there will be a device in the
> device tree for the ASoC board.
Sounds like you just solved the machine_is_xxx() problem in ASoC land too
there. If you're _already_ going for separate devices to describe the
ASoC stuff on the board, then there's no reason that couldn't have already
been done to eliminate the machine_is_xxx() usage in ASoC - rather than
complaining about machine_is_xxx() not being a very good solution.
As I said, the problem was solved years ago, and all the component parts
have been there also for years.
More information about the linaro-dev