[PATCH V4] ARM: EXYNOS4: Add machine support for 7" LCD on ORIGEN

Kukjin Kim kgene.kim at samsung.com
Fri Sep 16 12:02:18 UTC 2011


Tushar Behera wrote:
> 
> Dear Wolfgang Denk,
> 
> On Thursday 15 September 2011 02:44 PM, Wolfgang Denk wrote:
> > Dear Tushar Behera,
> >
> > In message<1316076867-2138-1-git-send-email-tushar.behera at linaro.org>
you
> wrote:
> >> ORIGEN board is fitted with 7" LCD panel HV070WSA. The pixel
> >> resolution of the LCD panel is 1024x600.
> > ...
> >> +static struct s3c_fb_pd_win origen_fb_win0 = {
> >> +	.win_mode = {
> >> +		.left_margin	= 64,
> >> +		.right_margin	= 16,
> >> +		.upper_margin	= 64,
> >> +		.lower_margin	= 16,
> >> +		.hsync_len	= 48,
> >> +		.vsync_len	= 3,
> >> +		.xres		= 1024,
> >> +		.yres		= 600,
> >> +	},
> >> +	.max_bpp		= 32,
> >> +	.default_bpp		= 24,
> >> +};
> >
> > Does it still make sense to hard-code such parameters?
> >
> > In PowerPC-land we pass display mode information in the device tree
> > using a verbatim EDID block.
> >
> > Would it be not better (and way more flexible) to do the same here,
> > now that ARM has device tree support?
> >
> Thanks for your suggestions.
> 
> Currently work for enabling device tree support for EXYNOS4 based
> machine is going on. Once it is done, we should be able to pass this
> information through device tree blob.
> 
> For non-DT machines, IMHO, we have to follow the current approach.

OK, applied.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.




More information about the linaro-dev mailing list