[PATCH 06/17][V2] ARM: OMAP4: cpuidle - use the omap4_idle_data variable directly
khilman at ti.com
Mon Apr 9 22:56:54 UTC 2012
Daniel Lezcano <daniel.lezcano at linaro.org> writes:
> We are storing the 'omap4_idle_data' in the private data field
> of the cpuidle device. As we are using this variable only in this file,
> that does not really make sense. Let's use the global variable directly
> instead dereferencing pointers in an idle critical loop.
Did you notice a performance impact before this change?
> Also, that simplfies the code.
possibly, but at the expense of clean abstractions which IMO helps readability.
Unless there is a real performance hit here (which I doubt), I'd prefer
to leave this as is.
More information about the linaro-dev