Fwd: [PATCHv2 0/5] coupled cpuidle state support

Amit Kucheria amit.kucheria at linaro.org
Tue Apr 10 08:54:52 UTC 2012


Andy,

TI seems to be happy with the cpuidle driver based on Colin's couple
C-state work. Santosh has provided a branch at the end of this message that
is rebased on top of 3.4-rc2. Can we fold this into the TILT tree for April?

Daniel,

You should provided a consolidated version of your fixes and cleanups to
the various LTs too.

/Amit

---------- Forwarded message ----------
From: Santosh Shilimkar <santosh.shilimkar at ti.com>
Date: Mon, Apr 9, 2012 at 10:11 AM
Subject: Re: [PATCHv2 0/5] coupled cpuidle state support
To: Colin Cross <ccross at android.com>
Cc: linux-kernel at vger.kernel.org, linux-arm-kernel at lists.infradead.org,
linux-pm at lists.linux-foundation.org, Kevin Hilman <khilman at ti.com>, Len
Brown <len.brown at intel.com>, Trinabh Gupta <g.trinabh at gmail.com>, Arjan van
de Ven <arjan at linux.intel.com>, Deepthi Dharwar <deepthi at linux.vnet.ibm.com>,
Greg Kroah-Hartman <gregkh at suse.de>, Kay Sievers <kay.sievers at vrfy.org>,
Daniel Lezcano <daniel.lezcano at linaro.org>, Amit Kucheria <
amit.kucheria at linaro.org>, Lorenzo Pieralisi <lorenzo.pieralisi at arm.com>,
Rob Lee <rob.lee at linaro.org>


On Friday 30 March 2012 06:23 PM, Santosh Shilimkar wrote:
> Colin,
>
> On Friday 16 March 2012 05:07 AM, Colin Cross wrote:
>> On Wed, Mar 14, 2012 at 11:29 AM, Colin Cross <ccross at android.com> wrote:
>
> [...]
>
>>>
>>> v2:
>>>   * removed the coupled lock, replacing it with atomic counters
>>>   * added a check for outstanding pokes before beginning the
>>>     final transition to avoid extra wakeups
>>>   * made the cpuidle_coupled struct completely private
>>>   * fixed kerneldoc comment formatting
>>>   * added a patch with a helper function for resynchronizing
>>>     cpus after aborting idle
>>>   * added a patch (not for merging) to add trace events for
>>>     verification and performance testing
>>
>> I forgot to mention, this patch series is on v3.3-rc7, and will
>> conflict with the cpuidle timekeeping patches.  If those go in first
>> (which is likely), I will rework this series on top of it.  I left it
>> on v3.3-rc7 now to make testing easier.
>
> I have re-based your series against Len Browns
> next branch [1] which has time keeping and other cpuidle patches.
> Have also folded the CPU hotplug fix which I posted in the
> original coupled idle patch.
>
As you know, we have been playing around this series for OMAP
for last few weeks. This version series seems to work as intended
and found it pretty stable in my testing. Apart from the cpu
hotplug fix and the trace event comment, series looks fine
to me.

FWIW,
Reviewed-by: Santosh Shilimkar <santosh.shilimkar at ti.com>
Tested-by: Santosh Shilimkar <santosh.shilimkar at ti.com>

An updated version of this series along with OMAP cpuidle
driver updates against 3.4-rc2 is available here [1] in
case some body is interested looking at it.

Regards
Santosh

[1] git://gitorious.org/omap-sw-develoment/linux-omap-dev.git
 for_3.5/coupled_cpuidle-rebase
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linaro.org/pipermail/linaro-dev/attachments/20120410/f784e2a9/attachment.html>


More information about the linaro-dev mailing list