[PATCH] ARM: pl330: fix null pointer dereference in pl330_chan_ctrl()

Boojin Kim boojin.kim at samsung.com
Thu Feb 9 00:44:51 UTC 2012


Javi Merino wrote:

> On 13/01/12 13:02, Russell King - ARM Linux wrote:
> > On Fri, Jan 13, 2012 at 12:36:31PM +0000, Mans Rullgard wrote:
> >> This fixes the thrd->req_running field being accessed before thrd
> >> is checked for null.  The error was introduced in abb959f.
> >>
> >> Signed-off-by: Mans Rullgard <mans.rullgard at linaro.org>
> >
> > I don't know what's happening with the PL330 driver, but there's patches
> > around to remove this file and merge it with the DMA engine driver.
>
> The PL330 merge didn't happen in the 3.3 merge window and I can't see it
> in linux-next, so linux 3.3 will ship with the driver still split in
> arch/arm/common/pl330.c and drivers/dma/pl330.c .  I think this patch
> should be part of linux 3.3 (and you should add "Cc: stable at kernel.org"
> so that it's included in the next 3.2 stable release).
>
> Unless somebody thinks otherwise, Mans, can you please submit it to
> rmk's patch tracking system?
I rebased your patch based on pl330 merge commit with kukjin kim. And confirmed to working it well. You can check it on below URL.
git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git v3.4-for-vkou
As I know, Kukjin kim will send a pull request to DMA and ARM SoC trees soon.

>
> http://www.arm.linux.org.uk/developer/patches/
>
> Thanks,
> Javi
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel





More information about the linaro-dev mailing list