[Powertop] [PATCH] conditionally disable pci support on ARM platforms

Marcin Juszkiewicz marcin.juszkiewicz at linaro.org
Sun Jun 24 19:28:36 UTC 2012


W dniu 22.06.2012 22:01, Arjan van de Ven pisze:
> On 6/22/2012 11:42 AM, Rajagopal Venkat wrote:
>> +case "$host" in
>> +arm*)
>> +	AC_DEFINE([HAVE_NO_PCI],[1],[Define if host platform is ARM])
>> +	;;
>> +*)
>> +	PKG_CHECK_MODULES([PCIUTILS], [libpci],[],[
>> +		AC_SEARCH_LIBS([pci_get_dev], [pci], [], AC_MSG_ERROR([libpci is required but was not found]), [])
>> +	])
>> +	;;
>> +esac
>> +
> 
> I don't like this part.
> 
> if libpci is option, it is optional.
> 
> being arm or not is completely irrelevant in this regard.
> (and there will undoubtedly ARM systems at some point that will have PCI
> in them)

Already there are ARM devices with PCI(e) support.



More information about the linaro-dev mailing list