[Powertop] [PATCH] conditionally disable pci support on ARM platforms
rajagopal.venkat at linaro.org
Mon Jun 25 05:24:38 UTC 2012
On 23 June 2012 01:31, Arjan van de Ven <arjan at linux.intel.com> wrote:
> On 6/22/2012 11:42 AM, Rajagopal Venkat wrote:
> > +case "$host" in
> > +arm*)
> > + AC_DEFINE([HAVE_NO_PCI],,[Define if host platform is ARM])
> > + ;;
> > +*)
> > + PKG_CHECK_MODULES([PCIUTILS], [libpci],,[
> > + AC_SEARCH_LIBS([pci_get_dev], [pci], ,
> AC_MSG_ERROR([libpci is required but was not found]), )
> > + ])
> > + ;;
> > +esac
> > +
> I don't like this part.
> if libpci is option, it is optional.
> Agree. libpci should be optional.
At present build script is enforcing to install libpci which may not be
necessarily true for all platforms. Solution can be something like,
AC_SEARCH_LIBS([pci_get_dev], [pci], ,
[AC_DEFINE([HAVE_NO_PCI],,[Define if pci is not supported])], )
> being arm or not is completely irrelevant in this regard.
> (and there will undoubtedly ARM systems at some point that will have PCI
> in them)
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the linaro-dev