[PATCH RESEND] arm/dt: Add mx51 babbage devicetree support
Shawn Guo
shawn.guo at freescale.com
Tue Mar 29 07:13:15 UTC 2011
Hi Grant,
On Tue, Mar 29, 2011 at 03:05:58PM +0800, Shawn Guo wrote:
> Enable basic device tree support on mx51 babbage
>
> Signed-off-by: Shawn Guo <shawn.guo at linaro.org>
> ---
> mx51_babbage_dt_match was put at an improper place, so resend the
> patch to fix it.
>
> arch/arm/boot/dts/babbage.dts | 19 +++++++++++++++++++
> arch/arm/mach-mx5/board-mx51_babbage.c | 6 ++++++
> 2 files changed, 25 insertions(+), 0 deletions(-)
> create mode 100644 arch/arm/boot/dts/babbage.dts
>
[...]
> diff --git a/arch/arm/mach-mx5/board-mx51_babbage.c b/arch/arm/mach-mx5/board-mx51_babbage.c
> index b2ecd19..30b92ca 100644
> --- a/arch/arm/mach-mx5/board-mx51_babbage.c
> +++ b/arch/arm/mach-mx5/board-mx51_babbage.c
> @@ -399,6 +399,11 @@ static struct sys_timer mx51_babbage_timer = {
> .init = mx51_babbage_timer_init,
> };
>
> +static const char *mx51_babbage_dt_match[] __initdata = {
It's not a problem, but it's always good to have consistency. I'm
seeing the guide line below suggests naming of *_dt_match, and
board-omap4panda.c does so. That's why I did so too.
http://lists.ozlabs.org/pipermail/devicetree-discuss/2011-March/005024.html
But mach-smdkv310.c and codes on devicetree/test are using another
naming scheme *_dt_compat to match the member .dt_compat below.
> + "fsl,mx51-babbage",
> + NULL
> +};
> +
> MACHINE_START(MX51_BABBAGE, "Freescale MX51 Babbage Board")
> /* Maintainer: Amit Kucheria <amit.kucheria at canonical.com> */
> .boot_params = MX51_PHYS_OFFSET + 0x100,
> @@ -407,4 +412,5 @@ MACHINE_START(MX51_BABBAGE, "Freescale MX51 Babbage Board")
> .init_irq = mx51_init_irq,
> .timer = &mx51_babbage_timer,
> .init_machine = mx51_babbage_init,
> + .dt_compat = mx51_babbage_dt_match,
> MACHINE_END
> --
--
Regards,
Shawn
More information about the linaro-kernel
mailing list