[PATCH 1/3] procfs: Export next_tgid(), move it to kernel/pid.c
Eric W. Biederman
ebiederm at xmission.com
Mon Jan 30 03:26:55 UTC 2012
Anton Vorontsov <anton.vorontsov at linaro.org> writes:
> We'd like to use this function in the android low memory killer driver, so
> let's export it.
> Also, move next_tgid() to kernel/pid.c, so now it lives with the rest of
> pid library functions and does not depend on procfs. Plus, we may now hide
> find_ge_pid() from the global namespace.
> While at it, also turn next_tgid()'s comments into kerneldoc format.
> There should be no functional changes.
There is find_ge_pid that is general purpose, and there are a lot of
things with the task list. But this iterator is specific to the
implementation of proc especially in how it grabs and drops locks.
Using this code outside of /proc will make /proc harder to maintain than
it already is.
Why in the world would you want to traverse processes by pids when
there are well defined iterators for looping over tasks already.
More information about the linaro-kernel