[PATCH 1/6] pstore: Add console log messages support

Anton Vorontsov anton.vorontsov at linaro.org
Wed May 16 22:33:46 UTC 2012


On Wed, May 16, 2012 at 09:49:11AM -0700, Kees Cook wrote:
[...]
> > +#ifdef CONFIG_PSTORE_CONSOLE
> > +static void pstore_console_write(struct console *con, const char *s, unsigned c)
> > +{
> > +       strncpy(psinfo->buf, s, c);
> 
> The size of psinfo->buf needs to be the length argument to strncpy,
> not the size of "s". If "s" isn't NULL terminated, then the min of c
> and buf's size should be used. And if this should be NULL terminated
> in buf, that needs to be added manually since strncpy won't do it if
> it hits the max length argument.

Whoops. Will fix it, thanks!

-- 
Anton Vorontsov
Email: cbouatmailru at gmail.com



More information about the linaro-kernel mailing list