[Linaro-mm-sig] [PATCH 1/1] dt: Add general DMA window parser

Thierry Reding thierry.reding at avionic-design.de
Wed Apr 18 10:26:29 UTC 2012


* Hiroshi Doyu wrote:
> +	cells = prop ? *(__be32 *)prop : of_n_addr_cells(dn);

I think this needs to be:

	cells = prop ? be32_to_cpup(prop) : of_n_addr_cells(dn);

Only casting isn't enough, you need the bytes to be swapped.

> +	cells = prop ? *(__be32 *)prop : of_n_size_cells(dn);

Similarly:

	cells = prop ? be32_to_cpup(prop) : of_n_size_cells(dn);

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.linaro.org/pipermail/linaro-mm-sig/attachments/20120418/d8de2877/attachment.pgp>


More information about the Linaro-mm-sig mailing list