On 12 June 2013 13:07, Olivier Martin olivier.martin@arm.com wrote:
Here is a copy of what I sent to Ryan earlier:
Unfortunately, I cannot remove the ArmPlatformLib from PL390Gic INF file even if it build in most cases. The reason is PL390GicSec now uses ArmPlatformIsPrimaryCore() that is implemented by ArmPlatformLib library. If one day one module uses PL390GicSec but does not depend itself on ArmPlatformLib then there is no reason why the engineer should add ArmPlatformLib to the INF file of this new module to solve PL390GicSec dependency.
A reason why it could fail would be you are using a different ArmPlatformLib implementation than the one you are thinking. A way to check that is to generate the build report: build -A ARM -p ... -t ... -y report.log And check which libraries are used by each module.
Actually, I am planning to rename 'PL390GicDxe' into 'ArmGicDxe' that will follow the 'ARM Generic Interrupt Controller Architecture Specification'.
Cheers, Olivier
Thanks Olivier!
I didn't see this before I replied to your email!
This patch will be dropped. We need to find a proper solution for Arndale. I *guess* it should just involve reworking the platform DSC/FDF/etc. files in [PATCH 1/2] to include the right things?
-----Original Message----- From: boot-architecture-bounces@lists.linaro.org [mailto:boot- architecture-bounces@lists.linaro.org] On Behalf Of Ryan Harkin Sent: 12 June 2013 12:03 To: ryan.harkin@linaro.org; boot-architecture@lists.linaro.org Subject: [PATCH 2/2] ArmPkg/PL390Gic: remove ArmPlatformLib from inf file
The PL390 GIC driver was including ArmPlatform in PL390GicSecLib.inf.
This change is fine as it, however, when the Arndale platfom is fixed to remove its duplicated PL390 GIC driver, it hangs unless this library is removed.
Signed-off-by: Ryan Harkin ryan.harkin@linaro.org
ArmPkg/Drivers/PL390Gic/PL390GicSecLib.inf | 1 - 1 file changed, 1 deletion(-)
diff --git a/ArmPkg/Drivers/PL390Gic/PL390GicSecLib.inf b/ArmPkg/Drivers/PL390Gic/PL390GicSecLib.inf index 205e503..5851bfe 100644 --- a/ArmPkg/Drivers/PL390Gic/PL390GicSecLib.inf +++ b/ArmPkg/Drivers/PL390Gic/PL390GicSecLib.inf @@ -31,7 +31,6 @@
[LibraryClasses] ArmLib
- ArmPlatformLib DebugLib IoLib PcdLib
-- 1.7.9.5
boot-architecture mailing list boot-architecture@lists.linaro.org http://lists.linaro.org/mailman/listinfo/boot-architecture
boot-architecture mailing list boot-architecture@lists.linaro.org http://lists.linaro.org/mailman/listinfo/boot-architecture