WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line) #9: branch stack events. To invoke the new functionality, use the perf inject tool ERROR: code indent should use tabs where possible #73: FILE: tools/perf/util/cs-etm.c:92: + /*$ ERROR: code indent should use tabs where possible #74: FILE: tools/perf/util/cs-etm.c:93: + * Stack of branches in reverse chronological order that will be copied$ ERROR: code indent should use tabs where possible #75: FILE: tools/perf/util/cs-etm.c:94: + * to a last branch event sample.$ ERROR: code indent should use tabs where possible #76: FILE: tools/perf/util/cs-etm.c:95: + */$ ERROR: code indent should use tabs where possible #77: FILE: tools/perf/util/cs-etm.c:96: + struct branch_stack *last_branch;$ WARNING: please, no spaces at the start of a line #77: FILE: tools/perf/util/cs-etm.c:96: + struct branch_stack *last_branch;$ ERROR: code indent should use tabs where possible #78: FILE: tools/perf/util/cs-etm.c:97: + /*$ ERROR: code indent should use tabs where possible #79: FILE: tools/perf/util/cs-etm.c:98: + * A circular buffer used to record last branches as they are decoded$ ERROR: code indent should use tabs where possible #80: FILE: tools/perf/util/cs-etm.c:99: + * from the trace.$ ERROR: code indent should use tabs where possible #81: FILE: tools/perf/util/cs-etm.c:100: + */$ ERROR: code indent should use tabs where possible #82: FILE: tools/perf/util/cs-etm.c:101: + struct branch_stack *last_branch_rb;$ WARNING: please, no spaces at the start of a line #82: FILE: tools/perf/util/cs-etm.c:101: + struct branch_stack *last_branch_rb;$ ERROR: code indent should use tabs where possible #83: FILE: tools/perf/util/cs-etm.c:102: + /*$ WARNING: line over 80 characters #84: FILE: tools/perf/util/cs-etm.c:103: + * Position in the circular buffer where the last branch has been inserted. ERROR: code indent should use tabs where possible #84: FILE: tools/perf/util/cs-etm.c:103: + * Position in the circular buffer where the last branch has been inserted.$ ERROR: code indent should use tabs where possible #85: FILE: tools/perf/util/cs-etm.c:104: + */$ ERROR: code indent should use tabs where possible #86: FILE: tools/perf/util/cs-etm.c:105: + size_t last_branch_pos;$ WARNING: please, no spaces at the start of a line #86: FILE: tools/perf/util/cs-etm.c:105: + size_t last_branch_pos;$ ERROR: code indent should use tabs where possible #94: FILE: tools/perf/util/cs-etm.c:226: + zfree(&etmq->last_branch);$ WARNING: please, no spaces at the start of a line #94: FILE: tools/perf/util/cs-etm.c:226: + zfree(&etmq->last_branch);$ ERROR: code indent should use tabs where possible #95: FILE: tools/perf/util/cs-etm.c:227: + zfree(&etmq->last_branch_rb);$ WARNING: please, no spaces at the start of a line #95: FILE: tools/perf/util/cs-etm.c:227: + zfree(&etmq->last_branch_rb);$ ERROR: code indent should use tabs where possible #103: FILE: tools/perf/util/cs-etm.c:392: + if (etm->synth_opts.last_branch) {$ WARNING: please, no spaces at the start of a line #103: FILE: tools/perf/util/cs-etm.c:392: + if (etm->synth_opts.last_branch) {$ ERROR: code indent should use tabs where possible #104: FILE: tools/perf/util/cs-etm.c:393: + size_t sz = sizeof(struct branch_stack);$ WARNING: please, no spaces at the start of a line #104: FILE: tools/perf/util/cs-etm.c:393: + size_t sz = sizeof(struct branch_stack);$ ERROR: code indent should use tabs where possible #106: FILE: tools/perf/util/cs-etm.c:395: + sz += etm->synth_opts.last_branch_sz *$ WARNING: please, no spaces at the start of a line #106: FILE: tools/perf/util/cs-etm.c:395: + sz += etm->synth_opts.last_branch_sz *$ ERROR: code indent should use tabs where possible #107: FILE: tools/perf/util/cs-etm.c:396: + sizeof(struct branch_entry);$ WARNING: please, no spaces at the start of a line #107: FILE: tools/perf/util/cs-etm.c:396: + sizeof(struct branch_entry);$ ERROR: code indent should use tabs where possible #108: FILE: tools/perf/util/cs-etm.c:397: + etmq->last_branch = zalloc(sz);$ WARNING: please, no spaces at the start of a line #108: FILE: tools/perf/util/cs-etm.c:397: + etmq->last_branch = zalloc(sz);$ ERROR: code indent should use tabs where possible #109: FILE: tools/perf/util/cs-etm.c:398: + if (!etmq->last_branch)$ WARNING: please, no spaces at the start of a line #109: FILE: tools/perf/util/cs-etm.c:398: + if (!etmq->last_branch)$ ERROR: code indent should use tabs where possible #110: FILE: tools/perf/util/cs-etm.c:399: + goto out_free;$ WARNING: please, no spaces at the start of a line #110: FILE: tools/perf/util/cs-etm.c:399: + goto out_free;$ ERROR: code indent should use tabs where possible #111: FILE: tools/perf/util/cs-etm.c:400: + etmq->last_branch_rb = zalloc(sz);$ WARNING: please, no spaces at the start of a line #111: FILE: tools/perf/util/cs-etm.c:400: + etmq->last_branch_rb = zalloc(sz);$ ERROR: code indent should use tabs where possible #112: FILE: tools/perf/util/cs-etm.c:401: + if (!etmq->last_branch_rb)$ WARNING: please, no spaces at the start of a line #112: FILE: tools/perf/util/cs-etm.c:401: + if (!etmq->last_branch_rb)$ ERROR: code indent should use tabs where possible #113: FILE: tools/perf/util/cs-etm.c:402: + goto out_free;$ WARNING: please, no spaces at the start of a line #113: FILE: tools/perf/util/cs-etm.c:402: + goto out_free;$ ERROR: code indent should use tabs where possible #114: FILE: tools/perf/util/cs-etm.c:403: + }$ WARNING: please, no spaces at the start of a line #114: FILE: tools/perf/util/cs-etm.c:403: + }$ ERROR: code indent should use tabs where possible #123: FILE: tools/perf/util/cs-etm.c:451: + zfree(&etmq->last_branch);$ WARNING: please, no spaces at the start of a line #123: FILE: tools/perf/util/cs-etm.c:451: + zfree(&etmq->last_branch);$ ERROR: code indent should use tabs where possible #124: FILE: tools/perf/util/cs-etm.c:452: + zfree(&etmq->last_branch_rb);$ WARNING: please, no spaces at the start of a line #124: FILE: tools/perf/util/cs-etm.c:452: + zfree(&etmq->last_branch_rb);$ ERROR: code indent should use tabs where possible #134: FILE: tools/perf/util/cs-etm.c:550: + struct branch_stack *bs_src = etmq->last_branch_rb;$ WARNING: please, no spaces at the start of a line #134: FILE: tools/perf/util/cs-etm.c:550: + struct branch_stack *bs_src = etmq->last_branch_rb;$ ERROR: code indent should use tabs where possible #135: FILE: tools/perf/util/cs-etm.c:551: + struct branch_stack *bs_dst = etmq->last_branch;$ WARNING: please, no spaces at the start of a line #135: FILE: tools/perf/util/cs-etm.c:551: + struct branch_stack *bs_dst = etmq->last_branch;$ ERROR: code indent should use tabs where possible #136: FILE: tools/perf/util/cs-etm.c:552: + size_t nr = 0;$ WARNING: please, no spaces at the start of a line #136: FILE: tools/perf/util/cs-etm.c:552: + size_t nr = 0;$ ERROR: code indent should use tabs where possible #138: FILE: tools/perf/util/cs-etm.c:554: + /*$ ERROR: code indent should use tabs where possible #139: FILE: tools/perf/util/cs-etm.c:555: + * Set the number of records before early exit: ->nr is used to$ ERROR: code indent should use tabs where possible #140: FILE: tools/perf/util/cs-etm.c:556: + * determine how many branches to copy from ->entries.$ ERROR: code indent should use tabs where possible #141: FILE: tools/perf/util/cs-etm.c:557: + */$ ERROR: code indent should use tabs where possible #142: FILE: tools/perf/util/cs-etm.c:558: + bs_dst->nr = bs_src->nr;$ WARNING: please, no spaces at the start of a line #142: FILE: tools/perf/util/cs-etm.c:558: + bs_dst->nr = bs_src->nr;$ ERROR: code indent should use tabs where possible #144: FILE: tools/perf/util/cs-etm.c:560: + /*$ ERROR: code indent should use tabs where possible #145: FILE: tools/perf/util/cs-etm.c:561: + * Early exit when there is nothing to copy.$ ERROR: code indent should use tabs where possible #146: FILE: tools/perf/util/cs-etm.c:562: + */$ ERROR: code indent should use tabs where possible #147: FILE: tools/perf/util/cs-etm.c:563: + if (!bs_src->nr)$ WARNING: please, no spaces at the start of a line #147: FILE: tools/perf/util/cs-etm.c:563: + if (!bs_src->nr)$ ERROR: code indent should use tabs where possible #148: FILE: tools/perf/util/cs-etm.c:564: + return;$ WARNING: please, no spaces at the start of a line #148: FILE: tools/perf/util/cs-etm.c:564: + return;$ ERROR: code indent should use tabs where possible #150: FILE: tools/perf/util/cs-etm.c:566: + /*$ ERROR: code indent should use tabs where possible #151: FILE: tools/perf/util/cs-etm.c:567: + * As bs_src->entries is a circular buffer, we need to copy from it in$ ERROR: code indent should use tabs where possible #152: FILE: tools/perf/util/cs-etm.c:568: + * two steps. First, copy the branches from the most recently inserted$ ERROR: code indent should use tabs where possible #153: FILE: tools/perf/util/cs-etm.c:569: + * branch ->last_branch_pos until the end of bs_src->entries buffer.$ ERROR: code indent should use tabs where possible #154: FILE: tools/perf/util/cs-etm.c:570: + */$ ERROR: code indent should use tabs where possible #155: FILE: tools/perf/util/cs-etm.c:571: + nr = etmq->etm->synth_opts.last_branch_sz - etmq->last_branch_pos;$ WARNING: please, no spaces at the start of a line #155: FILE: tools/perf/util/cs-etm.c:571: + nr = etmq->etm->synth_opts.last_branch_sz - etmq->last_branch_pos;$ ERROR: code indent should use tabs where possible #156: FILE: tools/perf/util/cs-etm.c:572: + memcpy(&bs_dst->entries[0],$ WARNING: please, no spaces at the start of a line #156: FILE: tools/perf/util/cs-etm.c:572: + memcpy(&bs_dst->entries[0],$ ERROR: code indent should use tabs where possible #157: FILE: tools/perf/util/cs-etm.c:573: + &bs_src->entries[etmq->last_branch_pos],$ WARNING: please, no spaces at the start of a line #157: FILE: tools/perf/util/cs-etm.c:573: + &bs_src->entries[etmq->last_branch_pos],$ ERROR: code indent should use tabs where possible #158: FILE: tools/perf/util/cs-etm.c:574: + sizeof(struct branch_entry) * nr);$ WARNING: please, no spaces at the start of a line #158: FILE: tools/perf/util/cs-etm.c:574: + sizeof(struct branch_entry) * nr);$ ERROR: code indent should use tabs where possible #160: FILE: tools/perf/util/cs-etm.c:576: + /*$ ERROR: code indent should use tabs where possible #161: FILE: tools/perf/util/cs-etm.c:577: + * If we wrapped around at least once, the branches from the beginning$ ERROR: code indent should use tabs where possible #162: FILE: tools/perf/util/cs-etm.c:578: + * of the bs_src->entries buffer and until the ->last_branch_pos element$ ERROR: code indent should use tabs where possible #163: FILE: tools/perf/util/cs-etm.c:579: + * are older valid branches: copy them over. The total number of$ ERROR: code indent should use tabs where possible #164: FILE: tools/perf/util/cs-etm.c:580: + * branches copied over will be equal to the number of branches asked by$ ERROR: code indent should use tabs where possible #165: FILE: tools/perf/util/cs-etm.c:581: + * the user in last_branch_sz.$ ERROR: code indent should use tabs where possible #166: FILE: tools/perf/util/cs-etm.c:582: + */$ ERROR: code indent should use tabs where possible #167: FILE: tools/perf/util/cs-etm.c:583: + if (bs_src->nr >= etmq->etm->synth_opts.last_branch_sz) {$ WARNING: please, no spaces at the start of a line #167: FILE: tools/perf/util/cs-etm.c:583: + if (bs_src->nr >= etmq->etm->synth_opts.last_branch_sz) {$ ERROR: code indent should use tabs where possible #168: FILE: tools/perf/util/cs-etm.c:584: + memcpy(&bs_dst->entries[nr],$ WARNING: please, no spaces at the start of a line #168: FILE: tools/perf/util/cs-etm.c:584: + memcpy(&bs_dst->entries[nr],$ ERROR: code indent should use tabs where possible #169: FILE: tools/perf/util/cs-etm.c:585: + &bs_src->entries[0],$ WARNING: please, no spaces at the start of a line #169: FILE: tools/perf/util/cs-etm.c:585: + &bs_src->entries[0],$ ERROR: code indent should use tabs where possible #170: FILE: tools/perf/util/cs-etm.c:586: + sizeof(struct branch_entry) * etmq->last_branch_pos);$ WARNING: please, no spaces at the start of a line #170: FILE: tools/perf/util/cs-etm.c:586: + sizeof(struct branch_entry) * etmq->last_branch_pos);$ ERROR: code indent should use tabs where possible #171: FILE: tools/perf/util/cs-etm.c:587: + }$ WARNING: please, no spaces at the start of a line #171: FILE: tools/perf/util/cs-etm.c:587: + }$ ERROR: code indent should use tabs where possible #176: FILE: tools/perf/util/cs-etm.c:592: + etmq->last_branch_pos = 0;$ WARNING: please, no spaces at the start of a line #176: FILE: tools/perf/util/cs-etm.c:592: + etmq->last_branch_pos = 0;$ ERROR: code indent should use tabs where possible #177: FILE: tools/perf/util/cs-etm.c:593: + etmq->last_branch_rb->nr = 0;$ WARNING: please, no spaces at the start of a line #177: FILE: tools/perf/util/cs-etm.c:593: + etmq->last_branch_rb->nr = 0;$ ERROR: code indent should use tabs where possible #181: FILE: tools/perf/util/cs-etm.c:597: + struct cs_etm_packet *packet)$ WARNING: please, no spaces at the start of a line #181: FILE: tools/perf/util/cs-etm.c:597: + struct cs_etm_packet *packet)$ ERROR: code indent should use tabs where possible #183: FILE: tools/perf/util/cs-etm.c:599: + struct branch_stack *bs = etmq->last_branch_rb;$ WARNING: please, no spaces at the start of a line #183: FILE: tools/perf/util/cs-etm.c:599: + struct branch_stack *bs = etmq->last_branch_rb;$ ERROR: code indent should use tabs where possible #184: FILE: tools/perf/util/cs-etm.c:600: + struct branch_entry *be;$ WARNING: please, no spaces at the start of a line #184: FILE: tools/perf/util/cs-etm.c:600: + struct branch_entry *be;$ ERROR: code indent should use tabs where possible #186: FILE: tools/perf/util/cs-etm.c:602: + /*$ ERROR: code indent should use tabs where possible #187: FILE: tools/perf/util/cs-etm.c:603: + * The branches are recorded in a circular buffer in reverse$ ERROR: code indent should use tabs where possible #188: FILE: tools/perf/util/cs-etm.c:604: + * chronological order: we start recording from the last element of the$ ERROR: code indent should use tabs where possible #189: FILE: tools/perf/util/cs-etm.c:605: + * buffer down. After writing the first element of the stack, move the$ ERROR: code indent should use tabs where possible #190: FILE: tools/perf/util/cs-etm.c:606: + * insert position back to the end of the buffer.$ ERROR: code indent should use tabs where possible #191: FILE: tools/perf/util/cs-etm.c:607: + */$ ERROR: code indent should use tabs where possible #192: FILE: tools/perf/util/cs-etm.c:608: + if (!etmq->last_branch_pos)$ WARNING: please, no spaces at the start of a line #192: FILE: tools/perf/util/cs-etm.c:608: + if (!etmq->last_branch_pos)$ ERROR: code indent should use tabs where possible #193: FILE: tools/perf/util/cs-etm.c:609: + etmq->last_branch_pos = etmq->etm->synth_opts.last_branch_sz;$ WARNING: please, no spaces at the start of a line #193: FILE: tools/perf/util/cs-etm.c:609: + etmq->last_branch_pos = etmq->etm->synth_opts.last_branch_sz;$ ERROR: code indent should use tabs where possible #195: FILE: tools/perf/util/cs-etm.c:611: + etmq->last_branch_pos -= 1;$ WARNING: please, no spaces at the start of a line #195: FILE: tools/perf/util/cs-etm.c:611: + etmq->last_branch_pos -= 1;$ ERROR: code indent should use tabs where possible #197: FILE: tools/perf/util/cs-etm.c:613: + be = &bs->entries[etmq->last_branch_pos];$ WARNING: please, no spaces at the start of a line #197: FILE: tools/perf/util/cs-etm.c:613: + be = &bs->entries[etmq->last_branch_pos];$ ERROR: code indent should use tabs where possible #198: FILE: tools/perf/util/cs-etm.c:614: + be->from = packet->start_addr;$ WARNING: please, no spaces at the start of a line #198: FILE: tools/perf/util/cs-etm.c:614: + be->from = packet->start_addr;$ ERROR: code indent should use tabs where possible #199: FILE: tools/perf/util/cs-etm.c:615: + be->to = packet->end_addr;$ WARNING: please, no spaces at the start of a line #199: FILE: tools/perf/util/cs-etm.c:615: + be->to = packet->end_addr;$ ERROR: code indent should use tabs where possible #200: FILE: tools/perf/util/cs-etm.c:616: + /* No support for mispredict */$ ERROR: code indent should use tabs where possible #201: FILE: tools/perf/util/cs-etm.c:617: + be->flags.mispred = 0;$ WARNING: please, no spaces at the start of a line #201: FILE: tools/perf/util/cs-etm.c:617: + be->flags.mispred = 0;$ ERROR: code indent should use tabs where possible #202: FILE: tools/perf/util/cs-etm.c:618: + be->flags.predicted = 1;$ WARNING: please, no spaces at the start of a line #202: FILE: tools/perf/util/cs-etm.c:618: + be->flags.predicted = 1;$ ERROR: code indent should use tabs where possible #204: FILE: tools/perf/util/cs-etm.c:620: + /*$ ERROR: code indent should use tabs where possible #205: FILE: tools/perf/util/cs-etm.c:621: + * Increment bs->nr until reaching the number of last branches asked by$ ERROR: code indent should use tabs where possible #206: FILE: tools/perf/util/cs-etm.c:622: + * the user on the command line.$ ERROR: code indent should use tabs where possible #207: FILE: tools/perf/util/cs-etm.c:623: + */$ ERROR: code indent should use tabs where possible #208: FILE: tools/perf/util/cs-etm.c:624: + if (bs->nr < etmq->etm->synth_opts.last_branch_sz)$ WARNING: please, no spaces at the start of a line #208: FILE: tools/perf/util/cs-etm.c:624: + if (bs->nr < etmq->etm->synth_opts.last_branch_sz)$ ERROR: code indent should use tabs where possible #209: FILE: tools/perf/util/cs-etm.c:625: + bs->nr += 1;$ WARNING: please, no spaces at the start of a line #209: FILE: tools/perf/util/cs-etm.c:625: + bs->nr += 1;$ ERROR: code indent should use tabs where possible #213: FILE: tools/perf/util/cs-etm.c:629: + struct perf_sample *sample, u64 type,$ WARNING: please, no spaces at the start of a line #213: FILE: tools/perf/util/cs-etm.c:629: + struct perf_sample *sample, u64 type,$ ERROR: code indent should use tabs where possible #214: FILE: tools/perf/util/cs-etm.c:630: + bool swapped)$ WARNING: please, no spaces at the start of a line #214: FILE: tools/perf/util/cs-etm.c:630: + bool swapped)$ ERROR: code indent should use tabs where possible #216: FILE: tools/perf/util/cs-etm.c:632: + event->header.size = perf_event__sample_event_size(sample, type, 0);$ WARNING: please, no spaces at the start of a line #216: FILE: tools/perf/util/cs-etm.c:632: + event->header.size = perf_event__sample_event_size(sample, type, 0);$ ERROR: code indent should use tabs where possible #217: FILE: tools/perf/util/cs-etm.c:633: + return perf_event__synthesize_sample(event, type, 0, sample, swapped);$ WARNING: please, no spaces at the start of a line #217: FILE: tools/perf/util/cs-etm.c:633: + return perf_event__synthesize_sample(event, type, 0, sample, swapped);$ ERROR: code indent should use tabs where possible #227: FILE: tools/perf/util/cs-etm.c:752: + if (etm->synth_opts.last_branch) {$ WARNING: please, no spaces at the start of a line #227: FILE: tools/perf/util/cs-etm.c:752: + if (etm->synth_opts.last_branch) {$ ERROR: code indent should use tabs where possible #228: FILE: tools/perf/util/cs-etm.c:753: + cs_etm__copy_last_branch_rb(etmq);$ WARNING: please, no spaces at the start of a line #228: FILE: tools/perf/util/cs-etm.c:753: + cs_etm__copy_last_branch_rb(etmq);$ ERROR: code indent should use tabs where possible #229: FILE: tools/perf/util/cs-etm.c:754: + sample.branch_stack = etmq->last_branch;$ WARNING: please, no spaces at the start of a line #229: FILE: tools/perf/util/cs-etm.c:754: + sample.branch_stack = etmq->last_branch;$ ERROR: code indent should use tabs where possible #230: FILE: tools/perf/util/cs-etm.c:755: + }$ WARNING: please, no spaces at the start of a line #230: FILE: tools/perf/util/cs-etm.c:755: + }$ ERROR: code indent should use tabs where possible #239: FILE: tools/perf/util/cs-etm.c:816: + if (etm->synth_opts.inject) {$ WARNING: please, no spaces at the start of a line #239: FILE: tools/perf/util/cs-etm.c:816: + if (etm->synth_opts.inject) {$ ERROR: code indent should use tabs where possible #240: FILE: tools/perf/util/cs-etm.c:817: + ret = cs_etm__inject_event(event, &sample,$ WARNING: please, no spaces at the start of a line #240: FILE: tools/perf/util/cs-etm.c:817: + ret = cs_etm__inject_event(event, &sample,$ ERROR: code indent should use tabs where possible #241: FILE: tools/perf/util/cs-etm.c:818: + etm->instructions_sample_type,$ WARNING: please, no spaces at the start of a line #241: FILE: tools/perf/util/cs-etm.c:818: + etm->instructions_sample_type,$ ERROR: code indent should use tabs where possible #242: FILE: tools/perf/util/cs-etm.c:819: + etm->synth_needs_swap);$ WARNING: please, no spaces at the start of a line #242: FILE: tools/perf/util/cs-etm.c:819: + etm->synth_needs_swap);$ ERROR: code indent should use tabs where possible #243: FILE: tools/perf/util/cs-etm.c:820: + if (ret)$ WARNING: please, no spaces at the start of a line #243: FILE: tools/perf/util/cs-etm.c:820: + if (ret)$ ERROR: code indent should use tabs where possible #244: FILE: tools/perf/util/cs-etm.c:821: + return ret;$ WARNING: please, no spaces at the start of a line #244: FILE: tools/perf/util/cs-etm.c:821: + return ret;$ ERROR: code indent should use tabs where possible #245: FILE: tools/perf/util/cs-etm.c:822: + }$ WARNING: please, no spaces at the start of a line #245: FILE: tools/perf/util/cs-etm.c:822: + }$ ERROR: code indent should use tabs where possible #254: FILE: tools/perf/util/cs-etm.c:831: + if (etm->synth_opts.last_branch)$ WARNING: please, no spaces at the start of a line #254: FILE: tools/perf/util/cs-etm.c:831: + if (etm->synth_opts.last_branch)$ ERROR: code indent should use tabs where possible #255: FILE: tools/perf/util/cs-etm.c:832: + cs_etm__reset_last_branch_rb(etmq);$ WARNING: please, no spaces at the start of a line #255: FILE: tools/perf/util/cs-etm.c:832: + cs_etm__reset_last_branch_rb(etmq);$ ERROR: code indent should use tabs where possible #264: FILE: tools/perf/util/cs-etm.c:922: + if (etm->synth_opts.last_branch)$ WARNING: please, no spaces at the start of a line #264: FILE: tools/perf/util/cs-etm.c:922: + if (etm->synth_opts.last_branch)$ ERROR: code indent should use tabs where possible #265: FILE: tools/perf/util/cs-etm.c:923: + attr.sample_type |= PERF_SAMPLE_BRANCH_STACK;$ WARNING: please, no spaces at the start of a line #265: FILE: tools/perf/util/cs-etm.c:923: + attr.sample_type |= PERF_SAMPLE_BRANCH_STACK;$ ERROR: code indent should use tabs where possible #282: FILE: tools/perf/util/cs-etm.c:950: + if (err)$ WARNING: please, no spaces at the start of a line #282: FILE: tools/perf/util/cs-etm.c:950: + if (err)$ ERROR: code indent should use tabs where possible #283: FILE: tools/perf/util/cs-etm.c:951: + return err;$ WARNING: please, no spaces at the start of a line #283: FILE: tools/perf/util/cs-etm.c:951: + return err;$ ERROR: code indent should use tabs where possible #284: FILE: tools/perf/util/cs-etm.c:952: + if (etmq->etm->synth_opts.last_branch) {$ WARNING: please, no spaces at the start of a line #284: FILE: tools/perf/util/cs-etm.c:952: + if (etmq->etm->synth_opts.last_branch) {$ ERROR: code indent should use tabs where possible #285: FILE: tools/perf/util/cs-etm.c:953: + *cpu = packet.cpu;$ WARNING: please, no spaces at the start of a line #285: FILE: tools/perf/util/cs-etm.c:953: + *cpu = packet.cpu;$ ERROR: code indent should use tabs where possible #288: FILE: tools/perf/util/cs-etm.c:955: + /*$ ERROR: code indent should use tabs where possible #289: FILE: tools/perf/util/cs-etm.c:956: + * FIXME: as the trace sampling does not work for now, (for$ ERROR: code indent should use tabs where possible #290: FILE: tools/perf/util/cs-etm.c:957: + * example perf inject --itrace=i100us will not generate events$ ERROR: code indent should use tabs where possible #291: FILE: tools/perf/util/cs-etm.c:958: + * every 100 micro-seconds), generate a last branch event after$ ERROR: code indent should use tabs where possible #292: FILE: tools/perf/util/cs-etm.c:959: + * having decoded last_branch_sz branch samples. This condition$ ERROR: code indent should use tabs where possible #293: FILE: tools/perf/util/cs-etm.c:960: + * should be rewritten as "if reached sampling period".$ ERROR: code indent should use tabs where possible #294: FILE: tools/perf/util/cs-etm.c:961: + */$ ERROR: code indent should use tabs where possible #295: FILE: tools/perf/util/cs-etm.c:962: + if (etmq->last_branch_rb->nr ==$ WARNING: please, no spaces at the start of a line #295: FILE: tools/perf/util/cs-etm.c:962: + if (etmq->last_branch_rb->nr ==$ ERROR: code indent should use tabs where possible #296: FILE: tools/perf/util/cs-etm.c:963: + etmq->etm->synth_opts.last_branch_sz) {$ WARNING: please, no spaces at the start of a line #296: FILE: tools/perf/util/cs-etm.c:963: + etmq->etm->synth_opts.last_branch_sz) {$ ERROR: code indent should use tabs where possible #297: FILE: tools/perf/util/cs-etm.c:964: + err = cs_etm__synth_instruction_sample(etmq, &packet);$ WARNING: please, no spaces at the start of a line #297: FILE: tools/perf/util/cs-etm.c:964: + err = cs_etm__synth_instruction_sample(etmq, &packet);$ ERROR: code indent should use tabs where possible #298: FILE: tools/perf/util/cs-etm.c:965: + if (err)$ WARNING: please, no spaces at the start of a line #298: FILE: tools/perf/util/cs-etm.c:965: + if (err)$ ERROR: code indent should use tabs where possible #299: FILE: tools/perf/util/cs-etm.c:966: + return err;$ WARNING: please, no spaces at the start of a line #299: FILE: tools/perf/util/cs-etm.c:966: + return err;$ ERROR: code indent should use tabs where possible #300: FILE: tools/perf/util/cs-etm.c:967: + }$ WARNING: please, no spaces at the start of a line #300: FILE: tools/perf/util/cs-etm.c:967: + }$ ERROR: code indent should use tabs where possible #301: FILE: tools/perf/util/cs-etm.c:968: + cs_etm__update_last_branch_rb(etmq, &packet);$ WARNING: please, no spaces at the start of a line #301: FILE: tools/perf/util/cs-etm.c:968: + cs_etm__update_last_branch_rb(etmq, &packet);$ ERROR: code indent should use tabs where possible #302: FILE: tools/perf/util/cs-etm.c:969: + } else if (packet.sample_type & CS_ETM_RANGE) {$ WARNING: please, no spaces at the start of a line #302: FILE: tools/perf/util/cs-etm.c:969: + } else if (packet.sample_type & CS_ETM_RANGE) {$ ERROR: code indent should use tabs where possible #310: FILE: tools/perf/util/cs-etm.c:982: + int cpu = 0;$ WARNING: please, no spaces at the start of a line #310: FILE: tools/perf/util/cs-etm.c:982: + int cpu = 0;$ WARNING: suspect code indent for conditional statements (12, 20) #317: FILE: tools/perf/util/cs-etm.c:1002: if (!err) + cs_etm__sample(etmq, &cpu); ERROR: code indent should use tabs where possible #319: FILE: tools/perf/util/cs-etm.c:1003: + cs_etm__sample(etmq, &cpu);$ WARNING: please, no spaces at the start of a line #319: FILE: tools/perf/util/cs-etm.c:1003: + cs_etm__sample(etmq, &cpu);$ ERROR: code indent should use tabs where possible #322: FILE: tools/perf/util/cs-etm.c:1006: + /*$ ERROR: code indent should use tabs where possible #323: FILE: tools/perf/util/cs-etm.c:1007: + * Generate a last branch event for the branches left in the circular$ ERROR: code indent should use tabs where possible #324: FILE: tools/perf/util/cs-etm.c:1008: + * buffer at the end of the trace.$ ERROR: code indent should use tabs where possible #325: FILE: tools/perf/util/cs-etm.c:1009: + */$ ERROR: code indent should use tabs where possible #326: FILE: tools/perf/util/cs-etm.c:1010: + if (etmq->etm->synth_opts.last_branch) {$ WARNING: please, no spaces at the start of a line #326: FILE: tools/perf/util/cs-etm.c:1010: + if (etmq->etm->synth_opts.last_branch) {$ ERROR: code indent should use tabs where possible #327: FILE: tools/perf/util/cs-etm.c:1011: + struct cs_etm_packet packet;$ WARNING: please, no spaces at the start of a line #327: FILE: tools/perf/util/cs-etm.c:1011: + struct cs_etm_packet packet;$ ERROR: code indent should use tabs where possible #328: FILE: tools/perf/util/cs-etm.c:1012: + struct branch_stack *bs = etmq->last_branch_rb;$ WARNING: please, no spaces at the start of a line #328: FILE: tools/perf/util/cs-etm.c:1012: + struct branch_stack *bs = etmq->last_branch_rb;$ ERROR: code indent should use tabs where possible #329: FILE: tools/perf/util/cs-etm.c:1013: + struct branch_entry *be = &bs->entries[etmq->last_branch_pos];$ WARNING: please, no spaces at the start of a line #329: FILE: tools/perf/util/cs-etm.c:1013: + struct branch_entry *be = &bs->entries[etmq->last_branch_pos];$ ERROR: code indent should use tabs where possible #330: FILE: tools/perf/util/cs-etm.c:1014: + packet.cpu = cpu;$ WARNING: Missing a blank line after declarations #330: FILE: tools/perf/util/cs-etm.c:1014: + struct branch_entry *be = &bs->entries[etmq->last_branch_pos]; + packet.cpu = cpu; WARNING: please, no spaces at the start of a line #330: FILE: tools/perf/util/cs-etm.c:1014: + packet.cpu = cpu;$ ERROR: code indent should use tabs where possible #331: FILE: tools/perf/util/cs-etm.c:1015: + packet.start_addr = be->from;$ WARNING: please, no spaces at the start of a line #331: FILE: tools/perf/util/cs-etm.c:1015: + packet.start_addr = be->from;$ ERROR: code indent should use tabs where possible #332: FILE: tools/perf/util/cs-etm.c:1016: + packet.end_addr = be->to;$ WARNING: please, no spaces at the start of a line #332: FILE: tools/perf/util/cs-etm.c:1016: + packet.end_addr = be->to;$ ERROR: code indent should use tabs where possible #334: FILE: tools/perf/util/cs-etm.c:1018: + err = cs_etm__synth_instruction_sample(etmq, &packet);$ WARNING: please, no spaces at the start of a line #334: FILE: tools/perf/util/cs-etm.c:1018: + err = cs_etm__synth_instruction_sample(etmq, &packet);$ ERROR: code indent should use tabs where possible #335: FILE: tools/perf/util/cs-etm.c:1019: + if (err)$ WARNING: please, no spaces at the start of a line #335: FILE: tools/perf/util/cs-etm.c:1019: + if (err)$ ERROR: code indent should use tabs where possible #336: FILE: tools/perf/util/cs-etm.c:1020: + return err;$ WARNING: please, no spaces at the start of a line #336: FILE: tools/perf/util/cs-etm.c:1020: + return err;$ ERROR: code indent should use tabs where possible #337: FILE: tools/perf/util/cs-etm.c:1021: + }$ WARNING: please, no spaces at the start of a line #337: FILE: tools/perf/util/cs-etm.c:1021: + }$ total: 144 errors, 96 warnings, 295 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile pop1.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.