On 19/01/2024 04:23, Tao Zhang wrote:

Add property "qcom,cmb_msr_num" to support CMB MSR(mux select register)
for TPDM. It specifies the number of CMB MSR registers supported by
the TDPM.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.

Missing "qcom,coresight-tpdm:" prefix.

Checked the example of other changes.

Which of the following prefixes do you prefer here?

dt-bindings: arm: qcom: coresight-tpdm:

dt-bindings: arm: qcom, coresight-tpdm:

Best,

Tao

With this fixed:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof