Suzuki K Poulose suzuki.poulose@arm.com writes:
Yes, please. I was going to suggest that. May be we could do that as a separate patch after fixing the problem here first (so that it can be back ported).
Hi, Suzuki,
I saw this suggestion after I had put together my v2 version of the patch, where I split the path and handle into separate arguments and also got rid of void* in a single patch. With that approach I think it only makes sense to do them together.
But if we instead were to make everything work with a single path argument, then I agree it would have made sense to change the type in a separate patch.
This was initially a perf_handle only used for the perf mode, and it didn't make sens to have a "perf" argument to "enable" which could be used for both sysfs and perf. Now that the path is a generic data structure, it makes sense to move everything to accept the path.
I'm fairly new to the entire coresight subsystem, so I might be getting this wrong. It looks to me like the perf handle is really part of the event so wouldn't logically make sense as part of the path? Am I understanding that correctly?
-Carl