22 Jun
2021
22 Jun
'21
12:58 p.m.
Hi Denis,
On Sun, Jun 20, 2021 at 10:21:57PM -1000, Denis Nikitin wrote:
[...]
I'd like to leave patch 1/3 out, and resend it if we get conclusion. At the meantime, @Denis, if you have observed any profiling result (or profiling quality) difference caused by patch 1, the feedback would be very valuable.
I evaluated AutoFDO profiles with benchmarks but I was only focused on the system-wide mode. And as I understood patch 1 fixes the issue in non system-wide mode.
Yes, patch 1 doesn't work for the system-wide mode. In the system-wide mode, CoreSight driver has its own reference counter to only allow the last CPU to fill trace data to AUX buffer.
Currently I'm OoO so I won't be able to do further evaluation.
No problem, thanks for the feedback!
Leo