Re: [PATCH v2 2/5] coresight: add coresight Trace NOC driver

On Thu, Mar 06, 2025 at 04:22:20PM +0800, Yuanfang Zhang wrote:

[...]

...

...

+static int trace_noc_init_default_data(struct trace_noc_drvdata *drvdata) +{

•   int atid;
  

•   atid = coresight_trace_id_get_system_id();
  

•   if (atid < 0)
  

•           return atid;
  

•   drvdata->atid = atid;
  

•   drvdata->freq_type = FREQ_TS;
  

I don't see anywhere uses FREQ. Please remove the unused definitions and related code.

it is used in trace_noc_enable_hw().

I understood some macros and definitions are used by seqential patches.

A good practice is code should be added only when they are used. This can allow every patch in neat way and easier for review.

Thanks, Leo

...

...

•   drvdata->flag_type = FLAG;
  

FLAG_TS is not used in the driver as well. Remove it.

it is used in trace_noc_enable_hw().