Re: [PATCH v2] Coresight: Narrow down the matching range of tpdm

On 09/10/2024 10:17, Songwei Chai wrote:

The format of tpdm's peripheral id is 1f0exx. To avoid potential conflicts in the future, update the .id_table's id to 0x001f0e00. This update will narrow down the matching range and prevent incorrect matches. For example, another component's peripheral id might be f0e00, which would incorrectly match the old id.

Fixes: b3c71626a9333b0b29f9921a39ce ("Coresight: Add coresight TPDM source driver") Signed-off-by: Songwei Chai quic_songchai@quicinc.com

---

drivers/hwtracing/coresight/coresight-tpdm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtracing/coresight/coresight-tpdm.c index b7d99e91ab84..3230d76aed90 100644 --- a/drivers/hwtracing/coresight/coresight-tpdm.c +++ b/drivers/hwtracing/coresight/coresight-tpdm.c @@ -1308,8 +1308,8 @@ static void tpdm_remove(struct amba_device *adev) */ static struct amba_id tpdm_ids[] = { {

• .id = 0x000f0e00,
  

• .mask = 0x000fff00,
  

• .id	= 0x001f0e00,
  

• .mask	= 0x00ffff00,
  

  }, { 0, 0, NULL }, };

Looks good to me, will queue this for v6.14. Apologies for missing the v6.13 cycle

Suzuki