Hi Neil / Riku / Peter,

Thanks for your help.

Now that I have some confidence that the changes are working fine, is it possible for one of you to review the code..? Or could you suggest someone who could do that for me. The code is available at: ( git clone git://git.linaro.org/people/anil.singhar/klibc-aarch64.git )

I would like to implement review feedback and make it available for upstreaming this week.

Thanks and Regards,
Anil



On 4 October 2013 20:31, Anil Singhar <anil.singhar@linaro.org> wrote:
Hi Peter,

Thanks for your help and feedback. The definition from your links did work for me. Now at least stat gives valid outputs and my gzip and ls, which depends on stat, work OK though gzip still doesn't compress for some unknown reason.

Best Regards,
Anil



On 3 October 2013 18:54, Peter Maydell <peter.maydell@linaro.org> wrote:
On 3 October 2013 22:13, Anil Singhar <anil.singhar@linaro.org> wrote:
> Plus I noticed that the original definition that was in klibc for aarch64
> (the one with which I have issues) is exactly same as that in x86_64 and
> there the test works fine.

The struct stat layout differs from architecture to architecture.
"This layout works on x86-64" says absolutely nothing about
whether it is the right layout for any other architecture.

I don't know where you got the stat layout you say you tried,
but that doesn't match what the kernel has:

arm64 uses the generic stat layout:
http://lxr.linux.no/#linux+v3.11.3/arch/arm64/include/uapi/asm/stat.h
which is defined here:
http://lxr.linux.no/#linux+v3.11.3/include/uapi/asm-generic/stat.h

-- PMM