Thanks for the review. I see the sprintf-to-sysfs_emit conversion was already applied in staging-next. Apologies for the noise
Doesn't apply for me.
On Thu, Mar 19, 2026 at 12:02:01PM +0000, Gabriel Rondon wrote:
> Replace sprintf() with sysfs_emit() in all sysfs attribute show
> functions. sysfs_emit() is aware of the sysfs buffer page size limit
> and should be used instead of sprintf() for sysfs show callbacks to
> prevent potential buffer overflows.
Please clearly state that there are no buffer overflows in the current
code.
>
> Also add the missing trailing newline to each output, which is the
> standard convention for sysfs attributes.
>
This changes the user space API so it could potentially break
a script.
regards,
dan carpenter