[PATCH -next] staging: greybus: arche-apb-ctrl: remove unnecessary platform_set_drvdata()
Remove unnecessary platform_set_drvdata(..., NULL) in ->remove(), the driver_data will be cleared in device_unbind_cleanup() after calling ->remove() in driver call code.
Signed-off-by: Yang Yingliang yangyingliang@huawei.com --- drivers/staging/greybus/arche-apb-ctrl.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/greybus/arche-apb-ctrl.c index 8541995008da..5c77c1813214 100644 --- a/drivers/staging/greybus/arche-apb-ctrl.c +++ b/drivers/staging/greybus/arche-apb-ctrl.c @@ -423,7 +423,6 @@ static void arche_apb_ctrl_remove(struct platform_device *pdev) { device_remove_file(&pdev->dev, &dev_attr_state); poweroff_seq(pdev); - platform_set_drvdata(pdev, NULL); }
static int __maybe_unused arche_apb_ctrl_suspend(struct device *dev)
On Fri, Aug 11, 2023 at 03:08:26PM +0800, Yang Yingliang wrote:
Remove unnecessary platform_set_drvdata(..., NULL) in ->remove(), the driver_data will be cleared in device_unbind_cleanup() after calling ->remove() in driver call code.
s/call/core/
Signed-off-by: Yang Yingliang yangyingliang@huawei.com
drivers/staging/greybus/arche-apb-ctrl.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/greybus/arche-apb-ctrl.c index 8541995008da..5c77c1813214 100644 --- a/drivers/staging/greybus/arche-apb-ctrl.c +++ b/drivers/staging/greybus/arche-apb-ctrl.c @@ -423,7 +423,6 @@ static void arche_apb_ctrl_remove(struct platform_device *pdev) { device_remove_file(&pdev->dev, &dev_attr_state); poweroff_seq(pdev);
- platform_set_drvdata(pdev, NULL);
}
Should be ok:
Reviewed-by: Johan Hovold johan@kernel.org
Johan
-
Johan Hovold -
Yang Yingliang