On 20-02-19, 10:24, Arnd Bergmann wrote:
On Wed, Feb 20, 2019 at 7:10 AM Viresh Kumar viresh.kumar@linaro.org wrote:
On 19-02-19, 22:17, Arnd Bergmann wrote:
On Tue, Feb 19, 2019 at 10:06 PM Nick Desaulniers ndesaulniers@google.com wrote:
On Tue, Feb 19, 2019 at 2:12 AM kernelci.org bot bot@kernelci.org wrote:
2 drivers/tee/optee/device.c:92:48: warning: suggest braces around initialization of subobject [-Wmissing-braces] 2 drivers/tee/optee/device.c:39:31: warning: suggest braces around initialization of subobject [-Wmissing-braces]
Nathan has sent patches for some of these new warnings: https://github.com/ClangBuiltLinux/linux/issues/370
The optee warnings came through arm-soc, and Nathan's patches got an Ack already, so I can merge them as well.
1 drivers/crypto/ccp/ccp-ops.c:2434:5: warning: stack frame size of 8832 bytes in function 'ccp_run_cmd' [-Wframe-larger-than=] 1 drivers/cpufreq/qcom-cpufreq-kryo.c:76:12: warning: stack frame size of 2560 bytes in function 'qcom_cpufreq_kryo_probe' [-Wframe-larger-than=] 1 drivers/block/drbd/drbd_state.c:1712:13: warning: stack frame size of 2368 bytes in function 'after_state_ch' [-Wframe-larger-than=] 1 drivers/block/drbd/drbd_receiver.c:933:12: warning: stack frame size of 3328 bytes in function 'conn_connect' [-Wframe-larger-than=] 1 block/blk-cgroup.c:931:12: warning: stack frame size of 2368 bytes in function 'blkcg_print_stat' [-Wframe-larger-than=] 1 8 warnings generated.
Arnd sent patches for three of these. Arnd, did you send the asan-stack patch (if so, do you have a link)?
I'm still doing some verification builds before sending it out.
There is also one remaining warning, this one appears due to an actual kernel code bug and still needs to be addressed properly (adding Ilia and Viresh to Cc):
drivers/cpufreq/qcom-cpufreq-kryo.c:76:12: error: stack frame size of 2240 bytes in function 'qcom_cpufreq_kryo_probe' [-Werror,-Wframe-larger-than=]
What is NR_CPUS in this case as I don't see the same issue with arm64 defconfig as NR_CPUS is 64 in that case ?
In linux-next, the default CONFIG_NR_CPUS has been raised to 256, as of commit 846a415bf440 ("arm64: default NR_CPUS to 256") With NR_CPUS=64, I don't see it either. The maximum supported value of NR_CPUS is 4096, and I think we should allow building with that as well. At the moment, that results in a frame size of 32880 bytes for me.
I have sent a fix for that, thanks.
https://lore.kernel.org/lkml/5919a74b74f466e803e07f70136517119dcd4560.155066...