On 05/12/2015 03:56 AM, fu.wei@linaro.org wrote:

From: Fu Wei <fu.wei@linaro.org>

The sbsa-gwdt.txt documentation in devicetree/bindings/watchdog is for
introducing SBSA(Server Base System Architecture) Generic Watchdog
device node info into FDT.

The subject line does not need a '.'.

Signed-off-by: Fu Wei <fu.wei@linaro.org>
---
  .../devicetree/bindings/watchdog/sbsa-gwdt.txt     | 36 ++++++++++++++++++++++
  1 file changed, 36 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt

diff --git a/Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt b/Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt
new file mode 100644
index 0000000..7fffb42
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt
@@ -0,0 +1,36 @@
+* SBSA(Server Base System Architecture) Generic Watchdog
+
+The SBSA Generic Watchdog Timer is used for resuming system operation
+after two stages of timeout.

"resuming system operation" ? Isn't it more like "resetting the system" ?

+More details: ARM-DEN-0029 - Server Base System Architecture (SBSA)
+
+Required properties:
+- compatible : Should at least contain "arm,sbsa-gwdt".
+
+- reg : base physical address of the frames and length of memory mapped region.
+
+- reg-names : Should contain the resource reg names to show the order of
+  the values in "reg".
+  Must include the following entries : "refresh", "control".
+
+- interrupts : Should at least contain WS0 interrupt,
+  the WS1 Signal is optional.
+
+- interrupt-names : Should contain the resource interrupt names.
+  Must include the following entries : "ws0". the "ws1" is optional.
+

s/the//

+Optional properties
+- timeout-sec : Watchdog pre-timeout and timeout values (in seconds).
+       The first is timeout values, then pre-timeout.
+

You'll need to copy the devicetree mailing list to get feedback on this file,
and to get feedback on the modified meaning of timeout-sec. Specific question
to answer is if timeout-sec should be used for both timeout and pre-timeout,
or if a new property such as pretimeout-sec should be introduced. This is
especially important since another property, early-timeout-sec, is in the
process of being added.

+Example for FVP Foundation Model v8:
+
+watchdog@2a450000 {
+       compatible = "arm,sbsa-gwdt";
+       reg = <0x0 0x2a450000 0 0x10000>,
+             <0x0 0x2a440000 0 0x10000>;

Does this warrant a more detailed explanation, or are people expected to know
how this is formatted ?

+       reg-names = "refresh", "control";
+       interrupts = <0 27 4>;
+       interrupt-names = "ws0"

Is there a missing ';' ?

+       timeout-sec = <10 5>;
+};