Hi Guenter,



On 8 May 2015 at 21:05, Guenter Roeck <linux@roeck-us.net> wrote:
On 05/07/2015 11:36 PM, Fu Wei wrote:
Hi Guenter,

I have another thought:
dose it makes sense to put this kind of check into
-------
#if SBSA_GWDT_DEBUG

#endif
-------
just for development and debugging resean?

just a suggestion, let me know if that is OK  :-)

#ifdef in code is discouraged.

#if defined(DEBUG)
    status = sbsa_gwdt_cf_read(SBSA_GWDT_WCS, wdd);
    /* Check if the watchdog was disabled */
    if (status & SBSA_GWDT_WCS_EN)
        return -EIO;
#endif

that isn't OK for you?

Guenter

Great thanks!


On 8 May 2015 at 12:58, Fu Wei <fu.wei@linaro.org <mailto:fu.wei@linaro.org>> wrote:

    Hi Guenter,

    Good point indeed, Thanks ,
    Kick them out right away, you won't see them in my next patchset

    Great thanks !! :-)


     On 8 May 2015 at 12:55, Guenter Roeck <linux@roeck-us.net <mailto:linux@roeck-us.net>> wrote:

        On 05/07/2015 09:42 PM, Fu Wei wrote:

            Hi Guenter,
            At least I never got this error, I borrow this from another WDT driver in mainline kernel, I think it's good to check if our operation is executed well.


        Not really. If it is unnecessary, it increases kernel size for
        no good reason. And I really dislike the argument that "others
        did it as well". Maybe they had a reason.

        I have seen an embedded system so cluttered with unnecessary
        checks that it ended up literally twice as large as it had to,
        and it had severe performance problems on top of that.
        So far Linux avoided that fate. I would prefer to keep it
        that way.

        Thanks,
        Guenter




    --
    Best regards,

    Fu Wei
    Software Engineer
    Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
     Ph: +86 21 61221326 <tel:%2B86%2021%2061221326>(direct)
    Ph: +86 186 2020 4684 <tel:%2B86%20186%202020%204684> (mobile)
    Room 1512, Regus One Corporate Avenue,Level 15,
    One Corporate Avenue,222 Hubin Road,Huangpu District,
    Shanghai,China 200021




--
Best regards,

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021




--
Best regards,

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021