On 16 May 2012 04:48, Tushar Behera <tushar.behera@linaro.org> wrote:
On 05/14/2012 10:31 PM, Sangwook Lee wrote:
> This patch changes the moulde name of ath6kl.
> For 3.4 kernel. the module name is "ath6kl_core.ko" but to sync
> with both Ubuntu and Android, it should be changed to "ath6kl.ko"
>
> Signed-off-by: Sangwook Lee <sangwook.lee>
> ---
>  drivers/net/wireless/ath/ath6kl/Makefile |   26 +++++++++++++-------------
>  1 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/Makefile b/drivers/net/wireless/ath/ath6kl/Makefile
> index 85746c3e..9e8f15b 100644
> --- a/drivers/net/wireless/ath/ath6kl/Makefile
> +++ b/drivers/net/wireless/ath/ath6kl/Makefile
> @@ -22,21 +22,21 @@
>  # Author(s): ="Atheros"
>  #------------------------------------------------------------------------------
>
> -obj-$(CONFIG_ATH6KL) += ath6kl_core.o
> -ath6kl_core-y += debug.o
> -ath6kl_core-y += hif.o
> -ath6kl_core-y += htc.o
> -ath6kl_core-y += bmi.o
> -ath6kl_core-y += cfg80211.o
> -ath6kl_core-y += init.o
> -ath6kl_core-y += main.o
> -ath6kl_core-y += txrx.o
> -ath6kl_core-y += wmi.o
> -ath6kl_core-y += core.o
> -ath6kl_core-$(CONFIG_NL80211_TESTMODE) += testmode.o
> +obj-$(CONFIG_ATH6KL) += ath6kl.o
> +ath6kl-y += debug.o
> +ath6kl-y += hif.o
> +ath6kl-y += htc.o
> +ath6kl-y += bmi.o
> +ath6kl-y += cfg80211.o
> +ath6kl-y += init.o
> +ath6kl-y += main.o
> +ath6kl-y += txrx.o
> +ath6kl-y += wmi.o
> +ath6kl-y += core.o
> +ath6kl-$(CONFIG_NL80211_TESTMODE) += testmode.o
>
>  obj-$(CONFIG_ATH6KL_SDIO) += ath6kl_sdio.o
> -ath6kl_sdio-y += sdio.o
> +ath6kl-y += sdio.o
>
>  obj-$(CONFIG_ATH6KL_USB) += ath6kl_usb.o
>  ath6kl_usb-y += usb.o
Similar observation here. If the module name has been changed upstream,
then we must use them in the distribution. That way, we can move forward
towards a common kernel.

Yes it is. In fact, Ubuntu and Android platform must use the new  name.
But it is to save time by doing it in the kernel. Later we can ask platform team.


For the time being, I will apply this to Samsung LT kernel.

--
Tushar Behera