On 08/21/2013 10:34 PM, Vishal Bhoj wrote:

> On 22 August 2013 10:56, John Stultz <john.stultz@linaro.org> wrote:
>
>> On 08/21/2013 09:56 PM, Vishal Bhoj wrote:
>>> Hi John,
>>>
>>> Should we update our existing Android config fragment to what google
>>> recommends ? Atleast the base config as per google's documentation:
>>> http://source.android.com/devices/tech/kernel.html
>> I suspect its probably a good idea.
>>
>>> I see that one of the Landing team kernel which is derived from
>>> linux-linaro builds with our android config fragment but fails to compile
>>> with the one mentioned in above link.
>>>
>> Thanks for the heads up. I think I've reproduced it:
>> drivers/usb/gadget/android.c: In function ‘rndis_function_bind_config’:
>> drivers/usb/gadget/android.c:599:2: error: too few arguments to function
>> ‘gether_setup_name’
>> In file included from drivers/usb/gadget/android.c:41:0:
>> drivers/usb/gadget/u_ether.c:758:17: note: declared here
>>
>> right?
>>
> Yes this was one of the issue.

Ok, I've just committed a fix to that here:
https://git.linaro.org/gitweb?p=people/jstultz/android.git;a=commitdiff;h=f4b6e629ec67e46e1ac6167058b172c152df92f8;hp=67f5af793504cd876be13b09ddc3a125d1052166

>  I saw 2 more errors:
> wrt XT module, there was an error was in xt_socket.c:
> /home/vishal.bhoj/android/xyz/kernel/linaro/xyz/net/netfilter/xt_socket.c:180:49:
> error: 'protocol' undeclared (first use in this function)
>    sk = nf_tproxy_get_sock_v4(dev_net(skb->dev), protocol,

This one I wasn't able to trigger. Could you send me the .config?

thanks
-john