On 12-11-30 11:13 AM, John Stultz wrote:

On 11/29/2012 06:04 PM, Zhangfei Gao wrote:

Provide a -O option to specify dir to put generated .config

This looks ok to me, although you might want to add some extra details in the commit log as to why this is useful.

Thanks John for the quick review, will add more details.

And one minor nit below.

thanks
-john

@@ -100,7 +112,7 @@ for MERGE_FILE in $MERGE_LIST ; do
done

if [ "$MAKE" = "false" ]; then
-    cp $TMP_FILE .config
+    cp $TMP_FILE $OUTPUT/.config
      echo "#"
      echo "# merged configuration written to .config (needs make)"

Should this echo have $output/.config?

There may be different message output for O=dir and O=dir/.

So for simplicity just use .config here, or we need add parse the dir has '/' or not.

For example using sed 's/[/ \t]*$//'.

Which one you prefer.

thanks
-john