Re: [PATCH V2 4/4] cpufreq: Get rid of "struct global_attr"

On Friday, February 22, 2013 07:47:44 AM Viresh Kumar wrote:

On 22 February 2013 05:15, Rafael J. Wysocki rjw@sisk.pl wrote:

...

Why did you change all of the lines of this macro instead of changing just the one line you needed to change?

I didn't like the indentation used within the macro. So did it.

In general, things like that are for separate cleanup patches. If you mix functional changes with cleanups, poeple get confused and it's difficult to see what's needed and what's "optional".

I know it's tempting to fix stuff like that along with doing functional changes and I do that sometimes. Not very often, though, and with care.

Thanks, Rafael