On Wednesday 14 of August 2013 17:37:47 Vikas Sajjan wrote:
Hi Tomasz,
On 14 August 2013 17:00, Tomasz Figa t.figa@samsung.com wrote:
Hi Vikas,
On Wednesday 14 of August 2013 16:32:59 Vikas Sajjan wrote:
changes since v2: - split the 5250 related modifications into a separate patch.
I'm not sure whether Kukjin's comment was about this, as it introduces a short bisect breakage between patch 1 and patch 2 from this series.
IMHO it would be more sensible to make first patch simply fix name of the node and then a separate patch adding the rtc node for exynos5420.
Are you saying that patch 1: should contain modifications for exynos5.dtsi and exynos5250.dtsi ( basically the RTC name change and status as "okay") patch 2: should contain modifications only for exynos5420.dtsi ( new RTC DT node )
Oh, I forgot about the status property. So ideally there should be 3 patches: - patch 1 changing exynos5.dtsi and exynos5250.dtsi to fix RTC node name, - patch 2 adding status="okay" to exynos5250.dtsi, - patch 3 adding RTC node to exynos5420.dtsi.
Best regards, Tomasz