From: "Zhang, Jesse(Jie)" To: "Koenig, Christian" CC: "Zhang, Yifan" , "Guo, Shikai" Subject: SYNCOBJ TIMELINE Test failed Thread-Topic: SYNCOBJ TIMELINE Test failed Thread-Index: AdiK2eFJ1vnMujutQ1edii0mGEcBtg== Date: Tue, 28 Jun 2022 10:44:24 +0000 Message-ID: Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: X-MS-Exchange-Organization-RecordReviewCfmType: 0 msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-06-28T10:28:26Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; =?utf-8?q?MSI?= =?utf-8?q?P=5FLabel=5F4342314e-0df4-4b58-84bf-38bed6170a0f=5FSiteId=3D3dd89?= =?utf-8?q?61f-e488-4e60-8e11-a82d994e183d=3B_MSIP=5FLabel=5F4342314e-0df4-4?= =?utf-8?q?b58-84bf-38bed6170a0f=5FActionId=3D58f7bc89-ae88-42d8-881f-b08e83?= =?utf-8?q?972f48=3B?= MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 x-ms-exchange-organization-originalclientipaddress: 180.167.199.181 x-ms-exchange-organization-originalserveripaddress: 2603:10b6:5:393::16 msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_enabled: true msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_setdate: 2022-06-28T10:44:20Z msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_method: Standard msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_name: General msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_actionid: db405586-14d8-41d4-b541-dec24b79ca73 msip_label_4342314e-0df4-4b58-84bf-38bed6170a0f_contentbits: 0 Content-Type: multipart/mixed; boundary="_004_DM4PR12MB51529E90A4913889A100C0A7E3B89DM4PR12MB5152namp_" MIME-Version: 1.0 --_004_DM4PR12MB51529E90A4913889A100C0A7E3B89DM4PR12MB5152namp_ Content-Type: multipart/alternative; boundary="_000_DM4PR12MB51529E90A4913889A100C0A7E3B89DM4PR12MB5152namp_" --_000_DM4PR12MB51529E90A4913889A100C0A7E3B89DM4PR12MB5152namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Christian, Our QA find the "Syncobj timeline" test failed on ubuntu22 (kernel version = 5.15.0-39). The relate ticket as following: https://ontrack-internal.amd.com/browse/SWDEV-343186 We trace the root cause of this issue, and found it cause by your patch. A= s the following: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?= id=3Dab66fdace8581ef3b4e7cf5381a168ed4058d779. I add a patch , please help to review. diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index 7e48dcd1bee4..d5db818f1c76 100644 --- a/drivers/gpu/drm/drm_syncobj.c +++ b/drivers/gpu/drm/drm_syncobj.c @@ -887,7 +887,7 @@ static int drm_syncobj_flatten_chain(struct dma_fence *= *f) goto free_fences; dma_fence_put(*f); - *f =3D &array->base; + *f =3D array->fences[0]; return 0; Attach the patch file. Thanks Jesse --_000_DM4PR12MB51529E90A4913889A100C0A7E3B89DM4PR12MB5152namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Official Use O= nly - General]

Hi Christian,

Our QA find the “Syncobj timeline” test = failed on ubuntu22 (kernel version 5.15.0-39). The relate ticket as f= ollowing:

https://ontrack-internal.amd.com/browse/SWDEV-343186<= /o:p>

We trace the root cause of this issue, and found it = cause by your patch. As the following:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/co= mmit/?id=3Dab66fdace8581ef3b4e7cf5381a168ed4058d779.

I add a patch , please help to review.

diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers= /gpu/drm/drm_syncobj.c

index 7e48dcd1bee4..d5db818f1c76 100644

--- a/drivers/gpu/drm/drm_syncobj.c

+++ b/drivers/gpu/drm/drm_syncobj.c

@@ -887,7 +887,7 @@ static int drm_syncobj_flatten_c= hain(struct dma_fence **f)

&nbs= p; goto free_fences;

dma_fence= _put(*f);

- *f =3D &ar= ray->base;

+ *f =3D array-&= gt;fences[0];

return 0;=

Attach the patch file.

Thanks

Jesse

--_000_DM4PR12MB51529E90A4913889A100C0A7E3B89DM4PR12MB5152namp_-- --_004_DM4PR12MB51529E90A4913889A100C0A7E3B89DM4PR12MB5152namp_ Content-Type: application/octet-stream; name="0001-fix-SYNCOBJ-TIMELINE-Test-failed.-update-the-point-o.patch" Content-Description: 0001-fix-SYNCOBJ-TIMELINE-Test-failed.-update-the-point-o.patch Content-Disposition: attachment; filename="0001-fix-SYNCOBJ-TIMELINE-Test-failed.-update-the-point-o.patch"; size=1012; creation-date="Tue, 28 Jun 2022 10:36:21 GMT"; modification-date="Thu, 30 Jun 2022 15:26:23 GMT" Content-Transfer-Encoding: base64 RnJvbSBmYWIwZWE0MTdiNjg0ZWI4MDE2ZTVjMWUwYTVkNTU4ZGViYWZlMjRkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBqaWUxemhhbiA8amVzc2UuemhhbmdAYW1kLmNvbT4KRGF0ZTog VHVlLCAyOCBKdW4gMjAyMiAxODoyNjozNyArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIGZpeCBTWU5D T0JKIFRJTUVMSU5FIFRlc3QgZmFpbGVkLiB1cGRhdGUgdGhlIHBvaW50IG9mCiBkbWFfZmVuY2Ug YnkgZmVuY2UgYXJyYXksIHJlcGxhY2UgdGhlIGJhc2Ugb2YgZG1hX2ZlbmNlCk1JTUUtVmVyc2lv bjogMS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRy YW5zZmVyLUVuY29kaW5nOiA4Yml0CgpTaWduZWQtb2ZmLWJ5OiBKZXNzZSBaaGFuZyA8SmVzc2Uu WmhhbmdAYW1kLmNvbT4KClJldmlld2VkLWJ5OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4u a29lbmlnQGFtZC5jb20+CgpSZXZpZXdlZC1ieTogTmlybW95IERhcyA8bmlybW95LmRhc0BsaW51 eC5pbnRlbC5jb20+Ci0tLQogZHJpdmVycy9ncHUvZHJtL2RybV9zeW5jb2JqLmMgfCAyICstCiAx IGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNvYmouYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fc3lu Y29iai5jCmluZGV4IDdlNDhkY2QxYmVlNC4uZDVkYjgxOGYxYzc2IDEwMDY0NAotLS0gYS9kcml2 ZXJzL2dwdS9kcm0vZHJtX3N5bmNvYmouYworKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNv YmouYwpAQCAtODg3LDcgKzg4Nyw3IEBAIHN0YXRpYyBpbnQgZHJtX3N5bmNvYmpfZmxhdHRlbl9j aGFpbihzdHJ1Y3QgZG1hX2ZlbmNlICoqZikKIAkJZ290byBmcmVlX2ZlbmNlczsKIAogCWRtYV9m ZW5jZV9wdXQoKmYpOwotCSpmID0gJmFycmF5LT5iYXNlOworCSpmID0gYXJyYXktPmZlbmNlc1sw XTsKIAlyZXR1cm4gMDsKIAogZnJlZV9mZW5jZXM6Ci0tIAoyLjI1LjEKCg== --_004_DM4PR12MB51529E90A4913889A100C0A7E3B89DM4PR12MB5152namp_--