Hi Liming,

See below two example-

1-      param@param-opensource:~/Development/edk2$ source edksetup.sh -h-

Loading previous configuration from $WORKSPACE/Conf/BuildEnv.sh

WORKSPACE: /home/param/Development/edk2

EDK_TOOLS_PATH: /home/param/Development/edk2/BaseTools

In above example edksetup.sh is not able to handle “-h-“ parameter it mean it can handle only “-?, -h,--help”.

If we give any other parameter except above mentioned. It cannot handle. It mean error handling is required.

Even the help message is not looking good.

2-      param@param-opensource:~/Development/edk2$ source edksetup.sh -h

BaseTools Usage: '. edksetup.sh'

Please note: This script must be 'sourced' so the environment can be changed.

(Either '. edksetup.sh' or 'source edksetup.sh')

This is expected behavior.

If this patch is not looking good, suggest me how it can be made better.

Regards

Parmeshwr

Hi,

  I have two comments.

1.       BaseTools parameter is required to be supported for compatibility, because this usage is mentioned in EDKII_UserManual.pdf document. Some users have used it. In fact, “. edksetup.sh BaseTools” is same to “. edksetup.sh”.

2.       In below script, BaseTools/BuildEnv $* can be cleanup to remove $*, because no parameter is required.

if [ -z "$WORKSPACE" ]

then

  . BaseTools/BuildEnv $*

else

  . $WORKSPACE/BaseTools/BuildEnv $*

fi

Thanks

Liming

Hi All,

I see there is a problem in “edksetup.sh” file. It accept one parameter “-?, -h, --help” for printing help message.

If we give any other parameter to this it goes and set old environment with help message.  Expected behavior should be either to print

The help message or set environment. It is not able to handle any garbage parameter.

I am sending patch for this problem, please review and commit to main stream.

Even help message was not clear I changes that also.

Incorrect behavior :

:~/Development/edk2$ source edksetup.sh ---jjdcncn

Loading previous configuration from $WORKSPACE/Conf/BuildEnv.sh

WORKSPACE: /home/param/Development/edk2

EDK_TOOLS_PATH: /home/param/Development/edk2/BaseTools

Correct behavior:

:~/Development/edk2$ source edksetup.sh -h

BaseTools Usage: '. edksetup.sh'

Please note: This script must be 'sourced' so the environment can be changed.

(Either '. edksetup.sh' or 'source edksetup.sh')

Correct behavior:

:~/Development/edk2$ source edksetup.sh

Loading previous configuration from $WORKSPACE/Conf/BuildEnv.sh

WORKSPACE: /home/param/Development/edk2

EDK_TOOLS_PATH: /home/param/Development/edk2/BaseTools

Best Regards,

Parmeshwr Prasad

Tel : +91-9743262018