Hi all
On 18 March 2016 at 15:53, Fu Wei fu.wei@linaro.org wrote:
Hi all,
On 9 March 2016 at 16:22, Fu Wei fu.wei@linaro.org wrote:
Hi Julien,
On 9 March 2016 at 15:10, Julien Grall julien.grall@arm.com wrote:
Hi,
On 08/03/2016 23:37, Fu Wei wrote:
On 8 March 2016 at 14:54, Andrei Borzenkov arvidjaar@gmail.com wrote: So speaking of loading additional modules/lack of initrd on ARM, I thinks that will (only) affect loading XSM. For this, I have discussed of that with Julien, I think : (1) the first module must be kernel (2) the second module must be initrd, if we have initrd (3) Start from the 2nd module, XEN will detect that if the module is a XSM by the XSM binary signature. if we get XSM as the second module, that means we have not initrd.
We need to update Xen for point (3). Fu Wei, could you send a patch for this?
Yes, I think I can do that.
I have posted the patch for this:
http://lists.xen.org/archives/html/xen-devel/2016-03/msg02430.html
git log ca32012341f3de7d3975407fb963e6028f0d0c8b commit ca32012341f3de7d3975407fb963e6028f0d0c8b Author: Fu Wei fu.wei@linaro.org Date: Wed Apr 6 00:46:36 2016 +0800
xen/arm64: check XSM Magic from the second unknown module.
This patch adds a has_xsm_magic helper function for detecting XSM from the second unknown module.
If Xen can't get the kind of module from compatible, we guess the kind of these unknowns respectively: (1) The first unknown must be kernel. (2) Detect the XSM Magic from the 2nd unknown: a. If it's XSM, set the kind as XSM, and that also means we won't load ramdisk; b. if it's not XSM, set the kind as ramdisk. So if user want to load ramdisk, it must be the 2nd unknown. We also detect the XSM Magic for the following unknowns, then set its kind according to the return value of has_xsm_magic.
By this way, arm64 behavior can be compatible to x86 and can simplify multi-arch bootloader such as GRUB.
Signed-off-by: Fu Wei fu.wei@linaro.org Acked-by: Daniel De Graaf dgdegra@tycho.nsa.gov Acked-by: Julien Grall julien.grall@arm.com
Since the patch for this has been merged into the staging branch of xen, Could some one help to review this patch or maybe merge this patchset into GRUB if that is OK for all of you :-)
please correct me if I misunderstand it
I'm fine with this plan, it matches the x86 behavior.
Great thanks for your review :-)
Cheers,
-- Julien Grall
-- Best regards,
Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021
-- Best regards,
Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021