I always build a single UEFI binary for Foundation and FVP Base models by defining ARM_FOUNDATION_FVP, so I guess I am now going to have problems when I run on an AEMv8 4+4 model?

What would setting cores to 8 and clusters to 2 do to the Foundation model?  Would it work OK?


On 3 April 2014 21:04, <oliviermartin@users.sourceforge.net> wrote:
Revision: 15430
          http://sourceforge.net/p/edk2/code/15430
Author:   oliviermartin
Date:     2014-04-03 20:04:39 +0000 (Thu, 03 Apr 2014)
Log Message:
-----------
ArmPlatformPkg/ArmVExpress-FVP-AArch64: Fixed number of cores and cluster for Base and Foundation models

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Olivier Martin <olivier.martin@arm.com>

Modified Paths:
--------------
    trunk/edk2/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-FVP-AArch64.dsc

Modified: trunk/edk2/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-FVP-AArch64.dsc
===================================================================
--- trunk/edk2/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-FVP-AArch64.dsc        2014-04-03 00:56:45 UTC (rev 15429)
+++ trunk/edk2/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-FVP-AArch64.dsc        2014-04-03 20:04:39 UTC (rev 15430)
@@ -1,5 +1,5 @@
 #
-#  Copyright (c) 2011-2013, ARM Limited. All rights reserved.
+#  Copyright (c) 2011-2014, ARM Limited. All rights reserved.
 #
 #  This program and the accompanying materials
 #  are licensed and made available under the terms and conditions of the BSD License
@@ -80,8 +80,14 @@
   gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"ARM Fixed Virtual Platform"
   gEmbeddedTokenSpaceGuid.PcdEmbeddedPrompt|"ARM-FVP"

+!ifndef ARM_FOUNDATION_FVP
   # Up to 8 cores on Base models. This works fine if model happens to have less.
   gArmPlatformTokenSpaceGuid.PcdCoreCount|8
+  gArmPlatformTokenSpaceGuid.PcdClusterCount|2
+!else
+  # Up to 4 cores on Foundation models. This works fine if model happens to have less.
+  gArmPlatformTokenSpaceGuid.PcdCoreCount|4
+!endif

   #
   # NV Storage PCDs. Use base of 0x0C000000 for NOR1

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.


------------------------------------------------------------------------------
_______________________________________________
edk2-commits mailing list
edk2-commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-commits