The struct _AMD_ISCP_DXE_PROTOCOL is given an early typedef, only to be defined as "typedef struct _AMD_ISCP_DXE_PROTOCOL..." later on. Delete the duplication.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm leif.lindholm@linaro.org --- .../AMD/Styx/Binary/AmdModulePkg/Include/Protocol/AmdIscpDxeProtocol.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Platforms/AMD/Styx/Binary/AmdModulePkg/Include/Protocol/AmdIscpDxeProtocol.h b/Platforms/AMD/Styx/Binary/AmdModulePkg/Include/Protocol/AmdIscpDxeProtocol.h index 5daeb0cbc2..50db778453 100644 --- a/Platforms/AMD/Styx/Binary/AmdModulePkg/Include/Protocol/AmdIscpDxeProtocol.h +++ b/Platforms/AMD/Styx/Binary/AmdModulePkg/Include/Protocol/AmdIscpDxeProtocol.h @@ -279,7 +279,6 @@ EFI_STATUS *---------------------------------------------------------------------------------------- */ /// ISCP DXE Protocol Structure -typedef struct _AMD_ISCP_DXE_PROTOCOL { AMD_EXECUTE_CPU_CORE_RESET AmdExecuteCpuCoreReset; ///< Execute CPU Core Reset AMD_EXECUTE_CPU_RETRIEVE_ID AmdExecuteCpuRetrieveId; ///< Execute CPU Retrieve ID @@ -304,6 +303,6 @@ struct _AMD_ISCP_DXE_PROTOCOL { AMD_EXECUTE_BMC_PRESENT AmdExecuteBmcPresent; ///< Execute BMC presence check AMD_EXECUTE_RETRIEVE_BERT_RECORD AmdExecuteRetrieveBertRecord; ///< Execute Retrieve Boot Error Record AMD_EXECUTE_REGISTER_ERROR_SOURCE AmdExecuteRegisterErrorSource; ///< Execute Register Generic Hardware Error Source -} AMD_ISCP_DXE_PROTOCOL; +};
#endif //_AMD_ISCP_DXE_PROTOCOL_H_
On 12 April 2017 at 21:47, Leif Lindholm leif.lindholm@linaro.org wrote:
The struct _AMD_ISCP_DXE_PROTOCOL is given an early typedef, only to be defined as "typedef struct _AMD_ISCP_DXE_PROTOCOL..." later on. Delete the duplication.
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leif Lindholm leif.lindholm@linaro.org
Reviewed-by: Ard Biesheuvel ard.biesheuvel@linaro.org
.../AMD/Styx/Binary/AmdModulePkg/Include/Protocol/AmdIscpDxeProtocol.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Platforms/AMD/Styx/Binary/AmdModulePkg/Include/Protocol/AmdIscpDxeProtocol.h b/Platforms/AMD/Styx/Binary/AmdModulePkg/Include/Protocol/AmdIscpDxeProtocol.h index 5daeb0cbc2..50db778453 100644 --- a/Platforms/AMD/Styx/Binary/AmdModulePkg/Include/Protocol/AmdIscpDxeProtocol.h +++ b/Platforms/AMD/Styx/Binary/AmdModulePkg/Include/Protocol/AmdIscpDxeProtocol.h @@ -279,7 +279,6 @@ EFI_STATUS *---------------------------------------------------------------------------------------- */ /// ISCP DXE Protocol Structure -typedef struct _AMD_ISCP_DXE_PROTOCOL { AMD_EXECUTE_CPU_CORE_RESET AmdExecuteCpuCoreReset; ///< Execute CPU Core Reset AMD_EXECUTE_CPU_RETRIEVE_ID AmdExecuteCpuRetrieveId; ///< Execute CPU Retrieve ID @@ -304,6 +303,6 @@ struct _AMD_ISCP_DXE_PROTOCOL { AMD_EXECUTE_BMC_PRESENT AmdExecuteBmcPresent; ///< Execute BMC presence check AMD_EXECUTE_RETRIEVE_BERT_RECORD AmdExecuteRetrieveBertRecord; ///< Execute Retrieve Boot Error Record AMD_EXECUTE_REGISTER_ERROR_SOURCE AmdExecuteRegisterErrorSource; ///< Execute Register Generic Hardware Error Source -} AMD_ISCP_DXE_PROTOCOL; +};
#endif //_AMD_ISCP_DXE_PROTOCOL_H_
2.11.0
-
Ard Biesheuvel -
Leif Lindholm