On 4 July 2012 22:11, Andy Doan <andy.doan@linaro.org> wrote:
On 07/04/2012 03:38 AM, YongQin Liu wrote:
+ Vishal

On 4 July 2012 16:33, YongQin Liu <yongqin.liu@linaro.org
<mailto:yongqin.liu@linaro.org>> wrote:

    Hi, All

    I have written a script used to connect the android with the wifi in
    our lava lab.
    Now we need to pass the ssid and password information to the script.
    But I think it's better to put the ssid and password in some place
    of our lava validation,
    then the script get the information from that place.
    Like put a file in /etc/lava/devices/wifi, and the content it
    contains like following:

        SSID=LAVA-WiFiTest01
        PASSWD=PASSWORD
        SSID2=LAVA-5GWiFiTest01
        PASSWD2=PASSWORD2

    then in the shell script, we can simply use
    "source /etc/lava/devices/wifi" to get the SSID and password
    information.

    And when we put the script into lava-android-test, we can trigger
    this script when we need in the test.

    How do you think about the place to put the devices information?
    is /etc/lava/devices/wifi ok? bluetooth should have the same problem
    I think.

Is this script serving as a test or a common library for other tests? We have the "$(OPTION)" concept right now, which might work. For an example see our sleep.py test where it has default options as well as support for overriding them. However, if you want this as some type of common library, this approach might be clumsy.

We can pass the ssid information via  $(OPTION), but I don't think it's better to pass the password information via $(OPTION) which will be public from the android-build.
What I am considering here is how should we pass the password information to tests.

Thanks,
Yongqin Liu