6 Feb
2023
6 Feb
'23
6:40 a.m.
From: Nicolin Chen nicolinc@nvidia.com Sent: Saturday, February 4, 2023 1:45 AM
On Fri, Feb 03, 2023 at 08:26:44AM +0000, Tian, Kevin wrote:
+/**
- iommu_group_replace_domain - replace the domain that a group is
attached to
- @new_domain: new IOMMU domain to replace with
- @group: IOMMU group that will be attached to the new domain
- This API allows the group to switch domains without being forced to
go to
- the blocking domain in-between.
- If the attached domain is a core domain (e.g. a default_domain), it will
act
- just like the iommu_attach_group().
I think you meant "the currently-attached domain", which implies a 'detached' state as you replied to Baolu.
Hmm, I don't see an implication, since we only have either "the attached domain" or "a new domain" in the context?
probably just me reading it as "the newly attached domain". 😊
With that being said, I can add "currently" in v2:
- If the currently attached domain is a core domain (e.g. a default_domain),
- it will act just like the iommu_attach_group().
this is clearer.