On 10/20/20 5:51 PM, Fenghua Yu wrote:
From: Reinette Chatre reinette.chatre@intel.com
The format "%sok" is used to print results of a test. If the test passes, the empty string is printed and if the test fails "not " is printed. This results in output of "ok" when test passes and "not ok" when test fails.
Fix one instance where "not" (without a space) is printed on test failure resulting in output of "notok" on test failure.
The commit summary is misleading. It isn't typo. You are adding a space to make the message correct?
Fixes: 78941183d1b1 ("selftests/resctrl: Add Cache QoS Monitoring (CQM) selftest") Signed-off-by: Reinette Chatre reinette.chatre@intel.com Signed-off-by: Fenghua Yu fenghua.yu@intel.com
tools/testing/selftests/resctrl/cmt_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/resctrl/cmt_test.c b/tools/testing/selftests/resctrl/cmt_test.c index 13b01e010238..6ffb56c6a1e2 100644 --- a/tools/testing/selftests/resctrl/cmt_test.c +++ b/tools/testing/selftests/resctrl/cmt_test.c @@ -58,7 +58,7 @@ static void show_cache_info(unsigned long sum_llc_occu_resc, int no_of_bits, else res = false;
- printf("%sok CMT: diff within %d, %d%%\n", res ? "" : "not",
- printf("%sok CMT: diff within %d, %d%%\n", res ? "" : "not ", MAX_DIFF, (int)MAX_DIFF_PERCENT);
printf("# diff: %ld\n", avg_diff);
thanks, -- Shuah