On Fri, 25 Oct 2024 09:40:10 +0800 Li Zhijian wrote:
readonly STATS="$(mktemp -p /tmp ns-XXXXXX)" readonly BASE=`basename $STATS`
It could be a mistake to write to $BASE rather than $STATS, where $STATS is used to save the NSTAT_HISTORY and it will be cleaned up before exit.
Agreed, although since we've been creating the wrong file this whole time and everything worked -- should we just just delete those two lines completely?
Similarly to patch 6 - please repost as a standalone patch so that our CI will test it. If you only CC a mailing list on subset of patches they are likely to be ignored by automation..