On Thu, Mar 30, 2023 at 4:12 AM Javier Martinez Canillas javierm@redhat.com wrote:
kernel test robot lkp@intel.com writes:
Hello,
[...]
All warnings (new ones prefixed by >>):
drivers/clk/.kunitconfig: warning: ignored by one of the .gitignore files drivers/gpu/drm/tests/.kunitconfig: warning: ignored by one of the .gitignore files drivers/gpu/drm/vc4/tests/.kunitconfig: warning: ignored by one of the .gitignore files drivers/hid/.kunitconfig: warning: ignored by one of the .gitignore files
drivers/input/tests/.kunitconfig: warning: ignored by one of the .gitignore files
KUnit folks, what should we do about this? I believe the correct thing here would be for these dot-files to not be ignored by git.
Not only to prevent these reports, but also to avoid the need to add them using `git add -f`, since is quite error prone and easy to miss.
I was thinking about posting the following patch:
From f1dc1733001682886458c23b676123635bc29da0 Mon Sep 17 00:00:00 2001 From: Javier Martinez Canillas javierm@redhat.com Date: Thu, 30 Mar 2023 13:04:42 +0200 Subject: [PATCH] .gitignore: Exclude KUnit config dot-files
Ah, I forgot/didn't realize lkp bot was complaining about .kunitconfig's. Agreed, we should go with something like that.
As I noted in my reply on the patch, there was a previous patch to do just the same thing here, https://lore.kernel.org/linux-kselftest/20230127145708.12915-1-andriy.shevch...
I'm not sure who is intended to pick up the patch, but maybe bringing up the fact this causes spurious warnings will help argue for the change.
Thanks, Daniel